unpack-tarballs: fixed shellcheck issues

Signed-off-by: Lars Erik Wik <[email protected]>

Author: larsewi

build-scripts/unpack-tarballs

@@ -1,11 +1,11 @@
 #!/bin/sh -x
 
-. $(dirname "$0")/functions
+. "$(dirname "$0")"/functions
 . detect-environment
 . compile-options
 
 SOURCE_TARBALL="$BASEDIR/output/tarballs/cfengine-3.*.tar.gz"
-MASTERFILES_TARBALL=$(ls $BASEDIR/output/tarballs/cfengine-masterfiles*.tar.gz | grep -v 'pkg.tar.gz$')
+MASTERFILES_TARBALL=$(grep -v 'pkg.tar.gz$' "$BASEDIR"/output/tarballs/cfengine-masterfiles*.tar.gz)
 
 # DELETE the git-checked-out directories, they are tainted with
 # ./configure artifacts anyway.  The tarballs are unpacked and symlinked
@@ -23,17 +23,17 @@ if [ -e "$BASEDIR/core/" ] || [ -e "$BASEDIR/masterfiles/" ]; then
     exit 1
 fi
 
-if [ x$PROJECT = xcommunity ]; then
+if [ "$PROJECT" = community ]; then
     sudo rm -rf "$BASEDIR/enterprise" "$BASEDIR/nova" "$BASEDIR/mission-portal"
 fi
 
 # NATIVE TAR is being used on purpose, and *not* GNU TAR.
 
 echo "UNPACKING SOURCE TARBALL AND SYMLINKING core"
-cd $BASEDIR
-gzip -dc $SOURCE_TARBALL | tar -xf -
+cd "$BASEDIR"
+gzip -dc "$SOURCE_TARBALL" | tar -xf -
 ln -s cfengine-3* core
 
 echo "UNPACKING MASTERFILES TARBALL AND SYMLINKING masterfiles/"
-gzip -dc $MASTERFILES_TARBALL | tar -xf -
+gzip -dc "$MASTERFILES_TARBALL" | tar -xf -
 ln -s cfengine-masterfiles-* masterfiles