Merge pull request #5601 from vpodzime/3.21.x-no_returncodes_error

vpodzime · web-flow · commit b48ad0107d1d · 2024-08-09T15:05:15.000+02:00
[3.21.x] Log errors for commands promises with exit codes not matching any _returncodes
diff --git a/cf-agent/retcode.c b/cf-agent/retcode.c
@@ -86,7 +86,7 @@ bool VerifyCommandRetcode(EvalContext *ctx, int retcode, const Attributes *a, co
 
         if (!matched)
         {
-            cfPS(ctx, info_or_verbose, PROMISE_RESULT_FAIL, pp, a,
+            cfPS(ctx, LOG_LEVEL_ERR, PROMISE_RESULT_FAIL, pp, a,
                  "Command related to promiser '%s' returned code '%d' not defined as promise kept, not kept or repaired; setting to failed",
                  pp->promiser, retcode);
             *result = PromiseResultUpdate(*result, PROMISE_RESULT_FAIL);

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ bool VerifyCommandRetcode(EvalContext ctx, int retcode, const Attributes a, co`
`86`	`86`
`87`	`87`	`if (!matched)`
`88`	`88`	`{`
`89`		`- cfPS(ctx, info_or_verbose, PROMISE_RESULT_FAIL, pp, a,`
	`89`	`+ cfPS(ctx, LOG_LEVEL_ERR, PROMISE_RESULT_FAIL, pp, a,`
`90`	`90`	`"Command related to promiser '%s' returned code '%d' not defined as promise kept, not kept or repaired; setting to failed",`
`91`	`91`	`pp->promiser, retcode);`
`92`	`92`	`result = PromiseResultUpdate(result, PROMISE_RESULT_FAIL);`