You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: documentation/UDACITY_Project_Rubric.md
+18-18Lines changed: 18 additions & 18 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -40,63 +40,63 @@ The project should have a structure like the one shown below. All files shown mu
40
40
41
41
### Usability
42
42
43
-
-[] All features are usable across modern desktop and phone browsers.
44
-
-[] Ensure the HTML elements, eg. texts and buttons, are proportionate and readable in small screen devices.
43
+
-[x] All features are usable across modern desktop and phone browsers.
44
+
-[x] Ensure the HTML elements, eg. texts and buttons, are proportionate and readable in small screen devices.
45
45
46
46
### Styling
47
47
48
-
-[] Styling is set up in a logical way.
49
-
-[] All interactive elements have hover states.
48
+
-[x] Styling is set up in a logical way.
49
+
-[x] All interactive elements have hover states.
50
50
51
51
### HTML Structure
52
52
53
-
-[] HTML structure should be indented properly with classes and ID’s that make sense.
53
+
-[x] HTML structure should be indented properly with classes and ID’s that make sense.
54
54
55
55
### Visual Design
56
56
57
-
-[] The design should clearly be different from the design used in projects 3 and 4.
57
+
-[x] The design should clearly be different from the design used in projects 3 and 4.
58
58
59
59
## API and JS Integration
60
60
61
61
---
62
62
63
63
### src > server > server.js
64
64
65
-
-[] server.js file should be taken directly from passed project 3 with the addition of added member: value pairs and the required API keys.
65
+
-[x] server.js file should be taken directly from passed project 3 with the addition of added member: value pairs and the required API keys.
66
66
67
67
### index.js
68
68
69
-
-[] src > client > index.js
70
-
-[] At least one function should be imported.
69
+
-[x] src > client > index.js
70
+
-[x] At least one function should be imported.
71
71
-[] At least one event listener should be imported.
72
72
(styles referenced in html/css)
73
73
74
74
### app.js
75
75
76
-
-[] src > client > js > app.js
77
-
-[] There should be URLS and API Keys for at least 3 APIs, including Geonames, Weatherbit, and Pixabay. You can feel free to use more than 3 APIs.
78
-
-[] There should be a primary object with placeholder member value pairs.
79
-
-[] There should be a primary function that is exported to index.js (index.js file should import the functions from other files).
76
+
-[x] src > client > js > app.js
77
+
-[x] There should be URLS and API Keys for at least 3 APIs, including Geonames, Weatherbit, and Pixabay. You can feel free to use more than 3 APIs.
78
+
-[x] There should be a primary object with placeholder member value pairs.
79
+
-[x] There should be a primary function that is exported to index.js (index.js file should import the functions from other files).
80
80
81
81
## Documentation
82
82
83
83
---
84
84
85
85
### README
86
86
87
-
-[] A README file is included detailing the app and all dependencies.
87
+
-[x] A README file is included detailing the app and all dependencies.
88
88
89
89
#### Other requirements
90
90
91
91
-[x] The Readme file should have non-default text in it that is specific to this project. It doesn’t have to be thorough, but should have some basic info. Bonus points if correct markdown is used.
92
92
93
93
### Comments
94
94
95
-
-[] Comments are present and effectively explain longer code procedure when necessary.
95
+
-[x] Comments are present and effectively explain longer code procedure when necessary.
96
96
97
97
### Code Quality
98
98
99
-
-[] Code is formatted with consistent, logical, and easy-to-read formatting as described in the Udacity JavaScript Style Guide.
99
+
-[x] Code is formatted with consistent, logical, and easy-to-read formatting as described in the Udacity JavaScript Style Guide.
100
100
101
101
## Suggestions to Make Your Project Stand Out!
102
102
@@ -108,7 +108,7 @@ At least one of these is required, but the rest are great additional ways to fur
108
108
-[] Pull in an image for the country from Pixabay API when the entered location brings up no results (good for obscure localities).
109
109
-[] Allow user to add multiple destinations on the same trip.
110
110
-[] Pull in weather for additional locations.
111
-
-[] Allow the user to add hotel and/or flight data.
111
+
-[x] Allow the user to add hotel and/or flight data.
112
112
-[] Multiple places to stay? Multiple flights?
113
113
-[] Integrate the REST Countries API to pull in data for the country - being visited.
114
114
-[] Allow the user to remove the trip.
@@ -117,6 +117,6 @@ At least one of these is required, but the rest are great additional ways to fur
117
117
-[] Incorporate icons into forecast.
118
118
-[] Allow user to Print their trip and/or export to PDF.
119
119
-[] Allow the user to add a todo list and/or packing list for their trip.
120
-
-[] Allow the user to add additional trips (this may take some heavy reworking, but is worth the challenge).
120
+
-[x] Allow the user to add additional trips (this may take some heavy reworking, but is worth the challenge).
121
121
-[] Automatically sort additional trips by countdown.
122
122
-[] Move expired trips to bottom/have their style change so it’s clear it’s expired.
0 commit comments