allow underscores in names (#66)

* allow underscores in names

* Update variables.tf

* Update variables.tf

* Update examples_complete_test.go

* Update examples_complete_test.go

* Update fixtures.us-east-1.tfvars

* Rename fixtures.us-east-1.tfvars to fixtures.us-east-2.tfvars

---------

Co-authored-by: Igor Rodionov <[email protected]>

Author: cornfeedhobo

examples/complete/fixtures.us-east-1.tfvars renamed to examples/complete/fixtures.us-east-2.tfvars

@@ -1,4 +1,4 @@
-region = "us-east-1"
+region = "us-east-2"
 
 namespace = "eg"
 

examples/complete/variables.tf

@@ -1,10 +1,6 @@
 variable "region" {
-  type = string
-}
-
-variable "retention_in_days" {
-  description = "Number of days you want to retain log events in the log group"
-  default     = "30"
+  type        = string
+  description = "AWS region"
 }
 
 variable "stream_names" {

main.tf

@@ -7,7 +7,7 @@ module "log_group_label" {
   version = "0.25.0"
 
   # Allow forward slashes
-  regex_replace_chars = "/[^a-zA-Z0-9-\\/]/"
+  regex_replace_chars = "/[^a-zA-Z0-9-_\\/]/"
 
   context = module.this.context
 }

test/src/examples_complete_test.go

@@ -22,10 +22,10 @@ func TestExamplesComplete(t *testing.T) {
 	terraformOptions := &terraform.Options{
 		TerraformDir: "../../examples/complete",
 		Upgrade:      true,
-		VarFiles:     []string{"fixtures.us-east-1.tfvars"},
+		VarFiles:     []string{"fixtures.us-east-2.tfvars"},
 		Vars: map[string]interface{}{
 			"attributes": attributes,
-			"region":     "us-east-1",
+			"region":     "us-east-2",
 		},
 	}
 
@@ -36,7 +36,7 @@ func TestExamplesComplete(t *testing.T) {
 	// Run `terraform output` to get the value of an output variable
 	logGroupArn := terraform.Output(t, terraformOptions, "log_group_arn")
 	// Verify we're getting back the outputs we expect
-	assert.Contains(t, logGroupArn, "arn:aws:logs:us-east-1:")
+	assert.Contains(t, logGroupArn, "arn:aws:logs:us-east-2:")
 
 	// Run `terraform output` to get the value of an output variable
 	streamArns := terraform.Output(t, terraformOptions, "stream_arns")