-
-
Notifications
You must be signed in to change notification settings - Fork 156
Clarifying GitHub OAuth token variable #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Wow, this is a pretty important change! Hopefully this can get merged quickly. |
/test all |
/test all |
💥 This pull request now has conflicts. Could you fix it @justnom? 🙏 |
This PR was closed due to inactivity and merge conflicts. 😭 |
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe descriptions for Terraform variables related to GitHub OAuth tokens were updated across documentation and configuration files. The changes clarify that these variables should reference the name of an SSM parameter containing the token, rather than the token value itself. No changes were made to variable types, defaults, or code logic. Changes
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
what
Clarifying what the
github_oauth_token
variable should contain.why
The
aws-codebuild
module changed the default type for thegithub_token
variable toPARAMTER_STORE
fromPLAINTEXT
in this commit cloudposse/terraform-aws-codebuild@d078282.references