Support declaring individual efs, docker, fsx volumes for tasks

[jbcom]

what

• Supports declaring separate volumes for efs, docker, and fsx
• This also decouples name and host_path which are expected to be passed uniquely in each volume variable declaration
• Maintains backwards compatibility by pulling apart the deprecated volumes variable into the new expected format

why

• terraform-aws-ecs-alb-service-task expects each of efs, docker, and fsx volumes to be passed separately
• Also expects name and host_port to be declared in each of the volume variable declarations
• Also allows for support for FSX volumes which are supported in the service-task module but not in this one.

references

• assign efs volumes configuration to efs_volume variable in ecs_alb_se… #205 partially implements this functionality but does not preserve backwards compatibility and does not setup FSX volumes

[mihaiplesa]

Is this ready to go? Seems like formatting failed.

[hans-d]

/terratest

[mergify]

💥 This pull request now has conflicts. Could you fix it @jbcom? 🙏

[mergify]

This PR was closed due to inactivity and merge conflicts. 😭
Please resolve the conflicts and reopen if necessary.

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The changes restructure the handling of volume configurations in Terraform code by splitting the previous mixed-type volumes variable into three distinct variables: efs_volumes, docker_volumes, and fsx_volumes. The deprecated volumes variable is retained for backward compatibility. Local variables aggregate and transform volume data, and the module invocation is updated to use the new variables.

Changes

Files	Change Summary
variables.tf	Split the original volumes variable into three new variables: efs_volumes, docker_volumes, and fsx_volumes, each with type definitions and descriptions specific to their respective volume types.
variables-deprecated.tf	Added a deprecated volumes variable, maintaining the previous mixed-type structure and marking it as deprecated in favor of the new variables.
main.tf	Introduced locals to extract and aggregate EFS and Docker volume configurations from the deprecated volumes variable. Updated the module "ecs_alb_service_task" block to accept efs_volumes, docker_volumes, and fsx_volumes as separate inputs, removing the previous docker_volumes = var.volumes argument.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ef7af53 and f8edbcf.

📒 Files selected for processing (3)

• main.tf (2 hunks)
• variables-deprecated.tf (1 hunks)
• variables.tf (2 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.