Skip to content

Replace Makefile with atmos.yaml #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025
Merged

Replace Makefile with atmos.yaml #301

merged 1 commit into from
May 29, 2025

Conversation

osterman
Copy link
Member

what

  • Remove Makefile
  • Add atmos.yaml

why

  • Replace build-harness with atmos for readme genration

References

  • DEV-3229 Migrate from build-harness to atmos

@osterman osterman added auto-update This PR was automatically generated no-release Do not create a new release (wait for additional code changes) migration This PR involves a migration labels May 29, 2025
@osterman osterman requested review from a team as code owners May 29, 2025 18:39
@osterman osterman added the auto-update This PR was automatically generated label May 29, 2025
@osterman osterman requested a review from kevcube May 29, 2025 18:39
@osterman osterman added the no-release Do not create a new release (wait for additional code changes) label May 29, 2025
@osterman osterman requested a review from jamengual May 29, 2025 18:39
@osterman osterman added the migration This PR involves a migration label May 29, 2025
Copy link

coderabbitai bot commented May 29, 2025

Warning

Rate limit exceeded

@osterman has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 46 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 75d6785 and 874d916.

📒 Files selected for processing (5)
  • Makefile (0 hunks)
  • README.yaml (2 hunks)
  • atmos.yaml (1 hunks)
  • docs/targets.md (0 hunks)
  • docs/terraform.md (0 hunks)
📝 Walkthrough

Walkthrough

This change removes the Makefile and its documentation, introduces an atmos.yaml configuration that imports a shared Atmos setup, and updates the README badge and documentation inclusion settings. The migration centralizes project configuration and documentation generation under Atmos, replacing previous build-harness and Makefile-based workflows.

Changes

Files / Paths Change Summary
Makefile, docs/targets.md, docs/terraform.md Removed Makefile and its related documentation files.
atmos.yaml Added new Atmos configuration file importing shared Terraform module config.
README.yaml Updated Slack badge URL and replaced the documentation include list with an empty list.

Assessment against linked issues

Objective Addressed Explanation
Deprecate build-harness and Makefile in favor of Atmos (DEV-3229)
Add organizational Atmos configuration and import it via atmos.yaml (DEV-3229)
Enable README generation and Terratest via Atmos commands (DEV-3229)
Update documentation references to Atmos and remove build-harness-specific instructions (DEV-3229)

Possibly related PRs


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@osterman osterman merged commit be124b0 into main May 29, 2025
13 of 45 checks passed
@osterman osterman deleted the migration/20250523 branch May 29, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update This PR was automatically generated migration This PR involves a migration no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant