Upgrade eslint #1115
Merged
Upgrade eslint #1115
+154
−175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cy-in-client Upgrade eslint and add flat config
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades ESLint from version 8 to version 9 and migrates the configuration format from the legacy .eslintrc JSON format to the new flat config format introduced in ESLint 9.
- Upgrades ESLint dependency from ^8.57.0 to ^9.30.1
- Replaces
.eslintrcJSON configuration with neweslint.config.jsflat config format - Maintains existing Prettier integration and configuration settings
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates ESLint dependency to version 9.30.1 |
| packages/client/.eslintrc | Removes legacy ESLint configuration file |
| packages/client/eslint.config.js | Adds new flat config format ESLint configuration |
| @@ -0,0 +1,22 @@ | |||
| const globals = require('globals') | |||
There was a problem hiding this comment.
The 'globals' package is imported but not listed as a dependency in package.json. This will cause a runtime error when ESLint tries to load the configuration.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major upgrade of eslint which uses a different file format for the configuration.