Skip to content

Commit 30aa32e

Browse files
Docker files clean up and unit test coverage (#425)
1 parent 5574c26 commit 30aa32e

File tree

11 files changed

+372
-320
lines changed

11 files changed

+372
-320
lines changed
Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
#
2-
#
31
# Copyright © 2023-2025 Dell Inc. or its subsidiaries. All Rights Reserved.
42
#
53
# Licensed under the Apache License, Version 2.0 (the "License");
@@ -11,13 +9,8 @@
119
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1210
# See the License for the specific language governing permissions and
1311
# limitations under the License.
14-
#
15-
#
16-
17-
# Dockerfile to build PowerStore CSI Driver
18-
# based on UBI-micro image
19-
# Requires: RHEL host with subscription
2012

13+
# some arguments that must be supplied
2114
ARG GOIMAGE
2215
ARG BASEIMAGE
2316

@@ -32,9 +25,7 @@ RUN GOOS=linux CGO_ENABLED=0 go build -o csi-powerstore ./cmd/csi-powerstore
3225

3326
# Stage to build the driver image
3427
FROM $BASEIMAGE
35-
3628
WORKDIR /
37-
3829
LABEL vendor="Dell Technologies" \
3930
maintainer="Dell Technologies" \
4031
name="csi-powerstore" \
@@ -43,7 +34,6 @@ LABEL vendor="Dell Technologies" \
4334
release="1.13.0" \
4435
version="2.13.0" \
4536
license="Apache-2.0"
46-
4737
COPY licenses /licenses
4838

4939
# validate some cli utilities are found

Makefile

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,6 @@
1919

2020
all: clean build
2121

22-
# Dockerfile defines which base image to use [Dockerfile.centos, Dockerfile.ubi, Dockerfile.ubi.min, Dockerfile.ubi.alt]
23-
# e.g.:$ make docker DOCKER_FILE=Dockerfile.ubi.alt
24-
ifndef DOCKER_FILE
25-
DOCKER_FILE = Dockerfile.ubi.micro
26-
endif
27-
2822
# Tag parameters
2923
ifndef MAJOR
3024
MAJOR=2
@@ -63,12 +57,12 @@ tag:
6357
# Generates the docker container (but does not push)
6458
docker:
6559
go run core/semver/semver.go -f mk >semver.mk
66-
make -f docker.mk DOCKER_FILE=docker-files/$(DOCKER_FILE) docker
60+
make -f docker.mk DOCKER_FILE=Dockerfile docker
6761

6862
# Same as `docker` but without cached layers and will pull latest version of base image
6963
docker-no-cache:
7064
go run core/semver/semver.go -f mk >semver.mk
71-
make -f docker.mk DOCKER_FILE=docker-files/$(DOCKER_FILE) docker-no-cache
65+
make -f docker.mk DOCKER_FILE=Dockerfile docker-no-cache
7266

7367
# Pushes container to the repository
7468
push: docker

docker-files/Dockerfile.centos

Lines changed: 0 additions & 45 deletions
This file was deleted.

docker-files/Dockerfile.ubi

Lines changed: 0 additions & 46 deletions
This file was deleted.

docker-files/Dockerfile.ubi.alt

Lines changed: 0 additions & 59 deletions
This file was deleted.

docker-files/Dockerfile.ubi.min

Lines changed: 0 additions & 52 deletions
This file was deleted.

mocks/NodeLabelsModifier.go

Lines changed: 66 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)