Skip to content

"env" helper does not function as expected #610

Open
@leoj3n

Description

@leoj3n

The value of NODE_ENV seems to become undefined after reattachment:

Development:

node_env

Production:

node_env_prod

Therefore the test in the provided example seems as though it would fail client side: https://github.com/donejs/done-ssr/blob/master/docs/env.md

I've also noticed a window-production mapping in steal config to remap the path of a module file on the browser client does not work. However, a duplicate mapping for window-development does work.

Why do both env.NODE_ENV and window-production seem to have issues on the client side?

Aren't we supposed to be able to check env.NODE_ENV client side and use window-production?

If so, could this be a problem with Heroku? Am I misunderstanding this feature or is this a bug?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions