Fix CQS signal modernize-use-emplace in fbcode/cachelib/experimental

Differential Revision: D82422642

fbshipit-source-id: 19379a9e1f058acd60f128a690ab3ca9aa051f8b

Author: generatedunixname89002005287564

cachelib/experimental/deprecated_objcache/tests/ObjectCacheTest.cpp

@@ -505,7 +505,7 @@ TEST(ObjCache, Destructor) {
     auto vec =
         objcache->create<VectorOfHeapString>(0 /* poolId */, "test vec string");
     for (int i = 0; i < 10; i++) {
-      vec->push_back("hello world 0123456789");
+      vec->emplace_back("hello world 0123456789");
     }
     // If destructor callback isn't properly executed, we would trigger
     // ASAN failures since std::string has heap storage
@@ -962,7 +962,7 @@ TEST(ObjectCache, PersistenceMultipleTypes) {
 
       auto vecStr = objcache->create<VecStr>(
           0 /* poolId */, "vec_str test " + folly::to<std::string>(j));
-      vecStr->push_back("hello world 1234567890");
+      vecStr->emplace_back("hello world 1234567890");
       objcache->insertOrReplace(vecStr);
 
       auto mapStr = objcache->create<MapStr>(
@@ -1177,7 +1177,7 @@ TEST(ObjectCache, SharedPromiseColocateObject) {
       };
   std::vector<std::thread> ts;
   for (auto& sf : semiFutures) {
-    ts.push_back(std::thread{readString, std::move(sf)});
+    ts.emplace_back(readString, std::move(sf));
   }
 
   {
@@ -1254,7 +1254,7 @@ TEST(ObjectCache, SharedPromiseColocateObject2) {
       };
   std::vector<std::thread> ts;
   for (auto& sf : semiFutures) {
-    ts.push_back(std::thread{readString, std::move(sf)});
+    ts.emplace_back(readString, std::move(sf));
   }
 
   {