Optimize helm install/uninstall to avoid releases listing (#3)

Signed-off-by: 玖宇 <[email protected]>
Co-authored-by: 玖宇 <[email protected]>

Author: Syspretor

pkg/action/install.go

@@ -538,12 +538,13 @@ func (i *Install) availableName() error {
 		return nil
 	}
 
-	h, err := i.cfg.Releases.History(start)
-	if err != nil || len(h) < 1 {
-		return nil
+	rel, err := i.cfg.Releases.Get(start, 1)
+	if err != nil {
+		if errors.Is(err, driver.ErrReleaseNotFound) {
+			return nil
+		}
+		return fmt.Errorf("fail to get release \"%s\": %v", start, err)
 	}
-	releaseutil.Reverse(h, releaseutil.SortByRevision)
-	rel := h[0]
 
 	if st := rel.Info.Status; i.Replace && (st == release.StatusUninstalled || st == release.StatusFailed) {
 		return nil

pkg/action/uninstall.go

@@ -73,19 +73,17 @@ func (u *Uninstall) Run(name string) (*release.UninstallReleaseResponse, error)
 		return nil, errors.Errorf("uninstall: Release name is invalid: %s", name)
 	}
 
-	rels, err := u.cfg.Releases.History(name)
+	rel, err := u.cfg.Releases.Get(name, 1)
 	if err != nil {
 		if u.IgnoreNotFound {
 			return nil, nil
 		}
 		return nil, errors.Wrapf(err, "uninstall: Release not loaded: %s", name)
 	}
-	if len(rels) < 1 {
+	if rel == nil {
 		return nil, errMissingRelease
 	}
-
-	releaseutil.SortByRevision(rels)
-	rel := rels[len(rels)-1]
+	rels := []*release.Release{rel}
 
 	// TODO: Are there any cases where we want to force a delete even if it's
 	// already marked deleted?