Skip to content

Commit bb93b91

Browse files
committed
better name for function
1 parent 142cd6b commit bb93b91

File tree

2 files changed

+13
-11
lines changed

2 files changed

+13
-11
lines changed

src/components/Applicant/index.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import React, { useState, useEffect } from 'react';
33
/*
44
This component is responsible of rendering individual applicant dialogs
55
*/
6-
const Applicant = ({ onAddApplicant, onCancelAdd, applicantToEdit, onCancelEdit, isFirstApplicant }) => {
6+
const Applicant = ({ onAddOrUpdateApplicant, onCancelAdd, applicantToEdit, onCancelEdit, isFirstApplicant }) => {
77
const [firstName, setFirstName] = useState('');
88
const [lastName, setLastName] = useState('');
99
const [mobileNumber, setMobileNumber] = useState('');
@@ -43,13 +43,13 @@ const Applicant = ({ onAddApplicant, onCancelAdd, applicantToEdit, onCancelEdit,
4343
}
4444
}, [isPrimary, isEditingPrimary]);
4545

46-
const handleAddApplicant = () => {
46+
const handleAddOrUpdateApplicant = () => {
4747

4848
if (!validateForm()) {
4949
return;
5050
}
5151

52-
if(onAddApplicant({ firstName, lastName, mobileNumber, email, isPrimary }).status === "failure"){
52+
if(onAddOrUpdateApplicant({ firstName, lastName, mobileNumber, email, isPrimary }).status === "failure"){
5353
setEmailWarning('Emails are not unique amongst applicants.');
5454
}else{
5555
setEmailWarning('');
@@ -163,7 +163,7 @@ const Applicant = ({ onAddApplicant, onCancelAdd, applicantToEdit, onCancelEdit,
163163
</label>
164164
<br />
165165
{emailWarning && <div className="Warning-message">{emailWarning}</div>}
166-
<button onClick={handleAddApplicant}>Ok</button>
166+
<button onClick={handleAddOrUpdateApplicant }>Ok</button>
167167
<button className="cancel" onClick={handleCancel}>
168168
Cancel
169169
</button>

src/components/Applicants/index.js

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,12 @@ const Applicants = () => {
4545
}
4646
}, [applicants]);
4747

48-
const handleAddApplicant = ({ firstName, lastName, mobileNumber, email, isPrimary }) => {
48+
const handleEditApplicant = (applicant) => {
49+
setAddingApplicant(false);
50+
setEditingApplicant(applicant);
51+
};
52+
53+
const handleAddOrUpdateApplicant = ({ firstName, lastName, mobileNumber, email, isPrimary }) => {
4954
if (hasDuplicates(email, editingApplicant?.id)) {
5055
return { status: 'failure', reason: 'has duplicates' };
5156
}
@@ -84,10 +89,7 @@ const Applicants = () => {
8489
return { status: 'success' };
8590
};
8691

87-
const handleEditApplicant = (applicant) => {
88-
setAddingApplicant(false);
89-
setEditingApplicant(applicant);
90-
};
92+
9193

9294
const handleDeleteApplicant = (applicant) => {
9395
setApplicants((prevApplicants) => prevApplicants.filter((a) => a.id !== applicant.id));
@@ -174,7 +176,7 @@ const Applicants = () => {
174176
</div>
175177
{(editingApplicant && editingApplicant.id === applicant.id) && (
176178
<Applicant
177-
onAddApplicant={handleAddApplicant}
179+
onAddOrUpdateApplicant={handleAddOrUpdateApplicant }
178180
onCancelAdd={handleCancelAdd}
179181
applicantToEdit={editingApplicant}
180182
onCancelEdit={handleCancelEdit}
@@ -185,7 +187,7 @@ const Applicants = () => {
185187
{addingApplicant && (
186188
<li key="new-applicant" className="Applicant-list-item">
187189
<Applicant
188-
onAddApplicant={handleAddApplicant}
190+
onAddOrUpdateApplicant={handleAddOrUpdateApplicant }
189191
onCancelAdd={handleCancelAdd}
190192
isFirstApplicant={applicants.length === 0}
191193
/>

0 commit comments

Comments
 (0)