Increase float precision in the inspector for Quaternions

Author: aaronfranke

editor/editor_properties.cpp

@@ -3917,7 +3917,14 @@ EditorProperty *EditorInspectorDefaultPlugin::get_editor_for_property(Object *p_
 		} break;
 		case Variant::QUATERNION: {
 			EditorPropertyQuaternion *editor = memnew(EditorPropertyQuaternion);
-			EditorPropertyRangeHint hint = _parse_range_hint(p_hint, p_hint_text, default_float_step);
+			// Quaternions are almost never used for human-readable values that need stepifying,
+			// so we should be more precise with their step, as much as the float precision allows.
+#ifdef REAL_T_IS_DOUBLE
+			constexpr double QUATERNION_STEP = 1e-14;
+#else
+			constexpr double QUATERNION_STEP = 1e-6;
+#endif
+			EditorPropertyRangeHint hint = _parse_range_hint(p_hint, p_hint_text, QUATERNION_STEP);
 			editor->setup(hint.min, hint.max, hint.step, hint.hide_slider, hint.suffix, p_hint == PROPERTY_HINT_HIDE_QUATERNION_EDIT);
 			return editor;
 		} break;

editor/gui/editor_spin_slider.cpp

@@ -109,16 +109,18 @@ void EditorSpinSlider::gui_input(const Ref<InputEvent> &p_event) {
 					pre_grab_value = get_max();
 				}
 
+				// Prevent dragging properties with very precise steps from being agonizingly slow.
+				const double drag_step = MAX(get_step(), 0.001);
 				if (mm->is_command_or_control_pressed()) {
 					// If control was just pressed, don't make the value do a huge jump in magnitude.
 					if (grabbing_spinner_dist_cache != 0) {
-						pre_grab_value += grabbing_spinner_dist_cache * get_step();
+						pre_grab_value += grabbing_spinner_dist_cache * drag_step;
 						grabbing_spinner_dist_cache = 0;
 					}
 
-					set_value(Math::round(pre_grab_value + get_step() * grabbing_spinner_dist_cache * 10));
+					set_value(Math::round(pre_grab_value + drag_step * grabbing_spinner_dist_cache * 10));
 				} else {
-					set_value(pre_grab_value + get_step() * grabbing_spinner_dist_cache);
+					set_value(pre_grab_value + drag_step * grabbing_spinner_dist_cache);
 				}
 			}
 		} else if (updown_offset != -1) {

editor/plugins/skeleton_3d_editor_plugin.cpp

@@ -73,7 +73,14 @@ void BonePropertiesEditor::create_editors() {
 
 	// Rotation property.
 	rotation_property = memnew(EditorPropertyQuaternion());
-	rotation_property->setup(-10000, 10000, 0.001, true);
+	// Quaternions are almost never used for human-readable values that need stepifying,
+	// so we should be more precise with their step, as much as the float precision allows.
+#ifdef REAL_T_IS_DOUBLE
+	constexpr double QUATERNION_STEP = 1e-14;
+#else
+	constexpr double QUATERNION_STEP = 1e-6;
+#endif
+	rotation_property->setup(-10000, 10000, QUATERNION_STEP, true);
 	rotation_property->set_label("Rotation");
 	rotation_property->set_selectable(false);
 	rotation_property->connect("property_changed", callable_mp(this, &BonePropertiesEditor::_value_changed));