Skip to content

Commit fcc00d4

Browse files
committed
Filter new test on win
1 parent d92c3a0 commit fcc00d4

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

plugins/hls-class-plugin/src/Ide/Plugin/Class/ExactPrint.hs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,7 @@ import Control.Lens (_head, over)
2323
makeEditText :: Monad m => ParsedModule -> DynFlags -> AddMinimalMethodsParams -> MaybeT m (T.Text, T.Text)
2424
makeEditText pm df AddMinimalMethodsParams{..} = do
2525
mDecls <- MaybeT . pure $ traverse (makeMethodDecl df) methodGroup
26-
let ps =
27-
makeDeltaAst $
28-
pm_parsed_source pm
26+
let ps = makeDeltaAst $ pm_parsed_source pm
2927

3028
old = T.pack $ exactPrint ps
3129
#if MIN_VERSION_ghc_exactprint(1,10,0)

plugins/hls-class-plugin/test/Main.hs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ codeActionTests = testGroup
4444
, "Add placeholders for all missing methods"
4545
, "Add placeholders for all missing methods with signature(s)"
4646
]
47-
, goldenWithClass "Creates a placeholder for '<>'" "T8" "diamond" $
48-
getActionByTitle "Add placeholders for '<>'"
4947
, goldenWithClass "Creates a placeholder for '=='" "T1" "eq" $
5048
getActionByTitle "Add placeholders for '=='"
5149
, goldenWithClass "Creates a placeholder for '/='" "T1" "ne" $
@@ -68,6 +66,12 @@ codeActionTests = testGroup
6866
getActionByTitle "Add placeholders for 'g','h'"
6967
, goldenWithClass "Creates a placeholder when all top-level decls are indented" "T7" "" $
7068
getActionByTitle "Add placeholders for 'g','h','i'"
69+
, testGroup "with preprocessors"
70+
[ knownBrokenInEnv [GhcVer GHC910]
71+
"See issue https://github.com/haskell/haskell-language-server/issues/4731 for details." $
72+
goldenWithClass "Creates a placeholder for '<>'" "T8" "diamond" $
73+
getActionByTitle "Add placeholders for '<>'"
74+
]
7175
, goldenWithClass "Don't insert pragma with GHC2021" "InsertWithGHC2021Enabled" "" $
7276
getActionByTitle "Add placeholders for '==' with signature(s)"
7377
, goldenWithClass "Insert pragma if not exist" "InsertWithoutPragma" "" $

0 commit comments

Comments
 (0)