Refactor to use StoreService instead of Store#677
Open
Dassderdie wants to merge 3 commits intodevfrom
Open
Conversation
benn02
reviewed
Feb 28, 2023
Contributor
benn02
left a comment
There was a problem hiding this comment.
LGTM, but this still has conflicts to be resolved. Please resolve them for approval.
Dassderdie
commented
Mar 18, 2023
Comment on lines
+28
to
+32
| this.currentLeader = this.assignLeaderBehaviorState.leaderId | ||
| ? this.storeService.select$( | ||
| createSelectPersonnel(this.assignLeaderBehaviorState.leaderId) | ||
| ) | ||
| : undefined; |
Collaborator
Author
There was a problem hiding this comment.
I believe I fixed a potential bug here:
If the leaderId would have changed back from an id to undefined, the component would still have displayed the previous leader.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StoreServicethat wraps the ngrx-storestoreService.select(selector)instead ofgetStateSnapshot(selector, store))exerciseService)Store<AppState>to get the typings - nowStoreServiceis enoughNearly all of the changes are just straightforward renaming.