Skip to content

Commit 66b22c9

Browse files
committed
fix: Don't disable bindless allocation using an undocumented env var
Bindless allocation is a core functionality. Having obscure mechanisms disabling it at runtime leads to unwanted side effects, leading to application issues, for example on applications trying to use SYCL bindless textures, that are supposed to be available unconditionally on DG2 and newer (when texturing is supported). This is what is assumed here: https://github.com/oneapi-src/unified-runtime/blob/dd7d5c6256f7ec90be9753e6e5a24d06a6b36fd6/source/adapters/level_zero/device.cpp#L1095 This reverts commit 81644a4. Signed-off-by: Xavier Hallade <[email protected]>
1 parent b33b423 commit 66b22c9

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

shared/source/device/root_device.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
#include "shared/source/helpers/gfx_core_helper.h"
1818
#include "shared/source/helpers/hw_info.h"
1919
#include "shared/source/memory_manager/memory_manager.h"
20-
#include "shared/source/os_interface/debug_env_reader.h"
2120
#include "shared/source/os_interface/os_context.h"
2221
#include "shared/source/utilities/software_tags_manager.h"
2322

@@ -51,10 +50,7 @@ Device *RootDevice::getRootDevice() const {
5150

5251
void RootDevice::createBindlessHeapsHelper() {
5352

54-
EnvironmentVariableReader envReader;
55-
bool disableGlobalBindless = envReader.getSetting("NEO_L0_SYSMAN_NO_CONTEXT_MODE", false);
56-
57-
if (!disableGlobalBindless && ApiSpecificConfig::getGlobalBindlessHeapConfiguration(this->getReleaseHelper()) && ApiSpecificConfig::getBindlessMode(*this)) {
53+
if (ApiSpecificConfig::getGlobalBindlessHeapConfiguration(this->getReleaseHelper()) && ApiSpecificConfig::getBindlessMode(*this)) {
5854
this->executionEnvironment->rootDeviceEnvironments[getRootDeviceIndex()]->createBindlessHeapsHelper(this, getNumGenericSubDevices() > 1);
5955
}
6056
}

0 commit comments

Comments
 (0)