[MLIR][NFC] Fix ambiguity between const char* and Twine (#175600)

aengelke · web-flow · commit 5f9092a19b9f · 2026-01-12T18:26:04.000Z
This only shows up once Twine gets included, e.g. through a pre-compiled
header. Avoid this ambiguity with an explicit cast.
diff --git a/mlir/lib/Support/TypeID.cpp b/mlir/lib/Support/TypeID.cpp
@@ -49,7 +49,7 @@ struct ImplicitTypeIDRegistry {
                    "`MLIR_DEFINE_EXPLICIT_TYPE_ID` or "
                    "`MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID`.\n";
       }
-      llvm::report_fatal_error(errorStr);
+      llvm::report_fatal_error(llvm::StringRef(errorStr));
     }
 #endif
 

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ struct ImplicitTypeIDRegistry {`
`49`	`49`	"`MLIR_DEFINE_EXPLICIT_TYPE_ID` or "
`50`	`50`	"`MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID`.\n";
`51`	`51`	`}`
`52`		`- llvm::report_fatal_error(errorStr);`
	`52`	`+ llvm::report_fatal_error(llvm::StringRef(errorStr));`
`53`	`53`	`}`
`54`	`54`	`#endif`
`55`	`55`