[NFCI][SYCL] Delegate to unspecialized get_device_info_impl more (#18113)

Author: aelovikov-intel

sycl/source/detail/device_info.hpp

@@ -186,15 +186,13 @@ template <typename ReturnT, typename Param> struct get_device_info_impl {
 // Specialization for platform
 template <typename Param> struct get_device_info_impl<platform, Param> {
   static platform get(const DeviceImplPtr &Dev) {
-    typename sycl_to_ur<platform>::type result;
-    Dev->getAdapter()->call<UrApiKind::urDeviceGetInfo>(
-        Dev->getHandleRef(), UrInfoCode<Param>::value, sizeof(result), &result,
-        nullptr);
     // TODO: Change UrDevice to device_impl.
     // Use the Adapter from the device_impl class after adapter details
     // are added to the class.
-    return createSyclObjFromImpl<platform>(
-        platform_impl::getOrMakePlatformImpl(result, Dev->getAdapter()));
+    return createSyclObjFromImpl<platform>(platform_impl::getOrMakePlatformImpl(
+        get_device_info_impl<typename sycl_to_ur<platform>::type, Param>::get(
+            Dev),
+        Dev->getAdapter()));
   }
 };
 
@@ -237,11 +235,8 @@ struct get_device_info_impl<std::vector<info::fp_config>, Param> {
             typename check_fp_support<Param>::type>::get(Dev)) {
       return {};
     }
-    ur_device_fp_capability_flags_t result;
-    Dev->getAdapter()->call<UrApiKind::urDeviceGetInfo>(
-        Dev->getHandleRef(), UrInfoCode<Param>::value, sizeof(result), &result,
-        nullptr);
-    return read_fp_bitfield(result);
+    return read_fp_bitfield(
+        get_device_info_impl<ur_device_fp_capability_flags_t, Param>::get(Dev));
   }
 };
 
@@ -250,11 +245,9 @@ template <>
 struct get_device_info_impl<std::vector<info::fp_config>,
                             info::device::single_fp_config> {
   static std::vector<info::fp_config> get(const DeviceImplPtr &Dev) {
-    ur_device_fp_capability_flags_t result;
-    Dev->getAdapter()->call<UrApiKind::urDeviceGetInfo>(
-        Dev->getHandleRef(), UrInfoCode<info::device::single_fp_config>::value,
-        sizeof(result), &result, nullptr);
-    return read_fp_bitfield(result);
+    return read_fp_bitfield(
+        get_device_info_impl<ur_device_fp_capability_flags_t,
+                             info::device::single_fp_config>::get(Dev));
   }
 };
 
@@ -263,11 +256,9 @@ struct get_device_info_impl<std::vector<info::fp_config>,
 // command_end will be calculated. See MFallbackProfiling
 template <> struct get_device_info_impl<bool, info::device::queue_profiling> {
   static bool get(const DeviceImplPtr &Dev) {
-    ur_queue_flags_t Properties;
-    Dev->getAdapter()->call<UrApiKind::urDeviceGetInfo>(
-        Dev->getHandleRef(), UrInfoCode<info::device::queue_profiling>::value,
-        sizeof(Properties), &Properties, nullptr);
-    return Properties & UR_QUEUE_FLAG_PROFILING_ENABLE;
+    return get_device_info_impl<ur_queue_flags_t,
+                                info::device::queue_profiling>::get(Dev) &
+           UR_QUEUE_FLAG_PROFILING_ENABLE;
   }
 };
 
@@ -276,12 +267,10 @@ template <>
 struct get_device_info_impl<std::vector<memory_order>,
                             info::device::atomic_memory_order_capabilities> {
   static std::vector<memory_order> get(const DeviceImplPtr &Dev) {
-    ur_memory_order_capability_flag_t result;
-    Dev->getAdapter()->call<UrApiKind::urDeviceGetInfo>(
-        Dev->getHandleRef(),
-        UrInfoCode<info::device::atomic_memory_order_capabilities>::value,
-        sizeof(result), &result, nullptr);
-    return readMemoryOrderBitfield(result);
+    return readMemoryOrderBitfield(
+        get_device_info_impl<
+            ur_memory_order_capability_flag_t,
+            info::device::atomic_memory_order_capabilities>::get(Dev));
   }
 };
 
@@ -290,12 +279,10 @@ template <>
 struct get_device_info_impl<std::vector<memory_order>,
                             info::device::atomic_fence_order_capabilities> {
   static std::vector<memory_order> get(const DeviceImplPtr &Dev) {
-    ur_memory_order_capability_flag_t result;
-    Dev->getAdapter()->call<UrApiKind::urDeviceGetInfo>(
-        Dev->getHandleRef(),
-        UrInfoCode<info::device::atomic_fence_order_capabilities>::value,
-        sizeof(result), &result, nullptr);
-    return readMemoryOrderBitfield(result);
+    return readMemoryOrderBitfield(
+        get_device_info_impl<
+            ur_memory_order_capability_flag_t,
+            info::device::atomic_fence_order_capabilities>::get(Dev));
   }
 };
 
@@ -304,12 +291,9 @@ template <>
 struct get_device_info_impl<std::vector<memory_scope>,
                             info::device::atomic_memory_scope_capabilities> {
   static std::vector<memory_scope> get(const DeviceImplPtr &Dev) {
-    size_t result;
-    Dev->getAdapter()->call<UrApiKind::urDeviceGetInfo>(
-        Dev->getHandleRef(),
-        UrInfoCode<info::device::atomic_memory_scope_capabilities>::value,
-        sizeof(result), &result, nullptr);
-    return readMemoryScopeBitfield(result);
+    return readMemoryScopeBitfield(
+        get_device_info_impl<
+            size_t, info::device::atomic_memory_scope_capabilities>::get(Dev));
   }
 };
 
@@ -318,12 +302,9 @@ template <>
 struct get_device_info_impl<std::vector<memory_scope>,
                             info::device::atomic_fence_scope_capabilities> {
   static std::vector<memory_scope> get(const DeviceImplPtr &Dev) {
-    size_t result;
-    Dev->getAdapter()->call<UrApiKind::urDeviceGetInfo>(
-        Dev->getHandleRef(),
-        UrInfoCode<info::device::atomic_fence_scope_capabilities>::value,
-        sizeof(result), &result, nullptr);
-    return readMemoryScopeBitfield(result);
+    return readMemoryScopeBitfield(
+        get_device_info_impl<
+            size_t, info::device::atomic_fence_scope_capabilities>::get(Dev));
   }
 };
 
@@ -355,12 +336,9 @@ struct get_device_info_impl<std::vector<info::execution_capability>,
                       "info::device::execution_capabilities is available for "
                       "backend::opencl only");
 
-    ur_device_exec_capability_flag_t result;
-    Dev->getAdapter()->call<UrApiKind::urDeviceGetInfo>(
-        Dev->getHandleRef(),
-        UrInfoCode<info::device::execution_capabilities>::value, sizeof(result),
-        &result, nullptr);
-    return read_execution_bitfield(result);
+    return read_execution_bitfield(
+        get_device_info_impl<ur_device_exec_capability_flag_t,
+                             info::device::execution_capabilities>::get(Dev));
   }
 };
 
@@ -457,12 +435,10 @@ struct get_device_info_impl<std::vector<info::partition_affinity_domain>,
                             info::device::partition_affinity_domains> {
   static std::vector<info::partition_affinity_domain>
   get(const DeviceImplPtr &Dev) {
-    ur_device_affinity_domain_flags_t result;
-    Dev->getAdapter()->call<UrApiKind::urDeviceGetInfo>(
-        Dev->getHandleRef(),
-        UrInfoCode<info::device::partition_affinity_domains>::value,
-        sizeof(result), &result, nullptr);
-    return read_domain_bitfield(result);
+    return read_domain_bitfield(
+        get_device_info_impl<
+            ur_device_affinity_domain_flags_t,
+            info::device::partition_affinity_domains>::get(Dev));
   }
 };