Skip to content

Commit a675319

Browse files
committed
[SYCL][UR][L0 v2] enable API logging through L0 loader
1 parent 0541ae0 commit a675319

File tree

3 files changed

+36
-28
lines changed

3 files changed

+36
-28
lines changed

unified-runtime/source/adapters/level_zero/adapter.cpp

+17
Original file line numberDiff line numberDiff line change
@@ -309,6 +309,12 @@ ur_adapter_handle_t_::ur_adapter_handle_t_()
309309

310310
if (UrL0Debug & UR_L0_DEBUG_BASIC) {
311311
logger.setLegacySink(std::make_unique<ur_legacy_sink>());
312+
#ifdef UR_ADAPTER_LEVEL_ZERO_V2
313+
setEnvVar("ZEL_ENABLE_LOADER_LOGGING", "1");
314+
setEnvVar("ZEL_LOADER_LOGGING_LEVEL", "trace");
315+
setEnvVar("ZEL_LOADER_LOG_CONSOLE", "1");
316+
setEnvVar("ZE_ENABLE_VALIDATION_LAYER", "1");
317+
#endif
312318
};
313319

314320
if (UrL0Debug & UR_L0_DEBUG_VALIDATION) {
@@ -419,6 +425,17 @@ ur_adapter_handle_t_::ur_adapter_handle_t_()
419425
loader_version.patch >= 2)) {
420426
useInitDrivers = true;
421427
}
428+
429+
#ifdef UR_ADAPTER_LEVEL_ZERO_V2
430+
if ((loader_version.major == 1 && loader_version.minor < 21) ||
431+
(loader_version.major == 1 && loader_version.minor == 21 &&
432+
loader_version.patch < 2)) {
433+
UR_LOG(
434+
WARN,
435+
"WARNING: Level Zero Loader version is older than 1.21.2. "
436+
"Please update to the latest version for API logging support.\n");
437+
}
438+
#endif
422439
}
423440

424441
if (useInitDrivers) {

unified-runtime/source/adapters/level_zero/common.cpp

+7
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,12 @@ void zeParseError(ze_result_t ZeError, const char *&ErrorString) {
137137
} // switch
138138
}
139139

140+
#ifdef UR_ADAPTER_LEVEL_ZERO_V2
141+
ze_result_t ZeCall::doCall(ze_result_t ZeResult, const char *, const char *,
142+
bool) {
143+
return ZeResult;
144+
}
145+
#else
140146
ze_result_t ZeCall::doCall(ze_result_t ZeResult, const char *ZeName,
141147
const char *ZeArgs, bool TraceError) {
142148
UR_LOG(DEBUG, "ZE ---> {}{}", ZeName, ZeArgs);
@@ -155,6 +161,7 @@ ze_result_t ZeCall::doCall(ze_result_t ZeResult, const char *ZeName,
155161
}
156162
return ZeResult;
157163
}
164+
#endif
158165

159166
// Specializations for various L0 structures
160167
template <> ze_structure_type_t getZeStructureType<ze_event_pool_desc_t>() {

unified-runtime/source/adapters/level_zero/v2/common.hpp

+12-28
Original file line numberDiff line numberDiff line change
@@ -15,24 +15,8 @@
1515

1616
#include "../common.hpp"
1717
#include "logger/ur_logger.hpp"
18-
namespace {
19-
#define DECLARE_DESTROY_FUNCTION(name) \
20-
template <typename ZeHandleT> ze_result_t name##_wrapped(ZeHandleT handle) { \
21-
return ZE_CALL_NOCHECK_NAME(name, (handle), #name); \
22-
}
23-
24-
#define HANDLE_WRAPPER_TYPE(handle, destroy) \
25-
ze_handle_wrapper<handle, destroy##_wrapped<handle>>
26-
} // namespace
2718

2819
namespace v2 {
29-
30-
DECLARE_DESTROY_FUNCTION(zeKernelDestroy)
31-
DECLARE_DESTROY_FUNCTION(zeEventDestroy)
32-
DECLARE_DESTROY_FUNCTION(zeEventPoolDestroy)
33-
DECLARE_DESTROY_FUNCTION(zeContextDestroy)
34-
DECLARE_DESTROY_FUNCTION(zeCommandListDestroy)
35-
DECLARE_DESTROY_FUNCTION(zeImageDestroy)
3620
namespace raii {
3721

3822
template <typename ZeHandleT, ze_result_t (*destroy)(ZeHandleT)>
@@ -108,23 +92,23 @@ struct ze_handle_wrapper {
10892
bool ownZeHandle;
10993
};
11094

111-
using ze_kernel_handle_t = HANDLE_WRAPPER_TYPE(::ze_kernel_handle_t,
112-
zeKernelDestroy);
95+
using ze_kernel_handle_t =
96+
ze_handle_wrapper<::ze_kernel_handle_t, zeKernelDestroy>;
11397

114-
using ze_event_handle_t = HANDLE_WRAPPER_TYPE(::ze_event_handle_t,
115-
zeEventDestroy);
98+
using ze_event_handle_t =
99+
ze_handle_wrapper<::ze_event_handle_t, zeEventDestroy>;
116100

117-
using ze_event_pool_handle_t = HANDLE_WRAPPER_TYPE(::ze_event_pool_handle_t,
118-
zeEventPoolDestroy);
101+
using ze_event_pool_handle_t =
102+
ze_handle_wrapper<::ze_event_pool_handle_t, zeEventPoolDestroy>;
119103

120-
using ze_context_handle_t = HANDLE_WRAPPER_TYPE(::ze_context_handle_t,
121-
zeContextDestroy);
104+
using ze_context_handle_t =
105+
ze_handle_wrapper<::ze_context_handle_t, zeContextDestroy>;
122106

123-
using ze_command_list_handle_t = HANDLE_WRAPPER_TYPE(::ze_command_list_handle_t,
124-
zeCommandListDestroy);
107+
using ze_command_list_handle_t =
108+
ze_handle_wrapper<::ze_command_list_handle_t, zeCommandListDestroy>;
125109

126-
using ze_image_handle_t = HANDLE_WRAPPER_TYPE(::ze_image_handle_t,
127-
zeImageDestroy);
110+
using ze_image_handle_t =
111+
ze_handle_wrapper<::ze_image_handle_t, zeImageDestroy>;
128112

129113
} // namespace raii
130114
} // namespace v2

0 commit comments

Comments
 (0)