Skip to content

Commit bbe079a

Browse files
committed
[UR][CUDA] Fix command-buffer handle inheritance
The `ur_exp_command_buffer_handle_t_` definition in the CUDA adapter was missed in #17118 in the changes to inherit from a base handle. Discovered by seeing segfaults in the UR CTS tests locally, and git bisecting back to that change.
1 parent b18e39d commit bbe079a

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

unified-runtime/source/adapters/cuda/command_buffer.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ ur_result_t commandHandleDestroy(
5757

5858
ur_exp_command_buffer_handle_t_::ur_exp_command_buffer_handle_t_(
5959
ur_context_handle_t Context, ur_device_handle_t Device, bool IsUpdatable)
60-
: Context(Context), Device(Device), IsUpdatable(IsUpdatable),
60+
: handle_base(), Context(Context), Device(Device), IsUpdatable(IsUpdatable),
6161
CudaGraph{nullptr}, CudaGraphExec{nullptr}, RefCount{1},
6262
NextSyncPoint{0} {
6363
urContextRetain(Context);

unified-runtime/source/adapters/cuda/command_buffer.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ struct ur_exp_command_buffer_command_handle_t_ : ur::cuda::handle_base {
128128
command_data_type_t CommandData;
129129
};
130130

131-
struct ur_exp_command_buffer_handle_t_ {
131+
struct ur_exp_command_buffer_handle_t_ : ur::cuda::handle_base {
132132

133133
ur_exp_command_buffer_handle_t_(ur_context_handle_t Context,
134134
ur_device_handle_t Device, bool IsUpdatable);

0 commit comments

Comments
 (0)