Add chapter selection to OSD #5011
Conversation
This comment has been minimized.
This comment has been minimized.
thornbill
added
feature
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Possible to add on 10.9 ? |
|
The 10.9 release is currently prepared and no more features are added: https://jellyfin.org/posts/testing-10.9.0 |
This comment has been minimized.
This comment has been minimized.
|
I like the idea. This resembles the same menu I created on Roku 🤘 If I click the Chapters button and click somewhere outside of the menu to close it (meaning, I did not click on a chapter), I get the following error: |
|
That error is an artifact of our weird dialog code that rejects when closed... a couple places depend on it though so probably just need a catch to suppress it here. |
|
The settings, audio selection and subtitle selection are also affected by this. .catch(() => {
// prevent 'ActionSheet closed without resolving' error
})or only the .catch((error) => {
// supress 'ActionSheet closed without resolving' error
// log and throw all other errors
if (error !== 'ActionSheet closed without resolving') {
console.error('ActionSheet error', error);
throw new Error(error);
}
})just let me now and I will provide a fix for this. |
|
I would just catch all for now. |
prevent error when ActionSheet dialog is closed without selection
|
Cloudflare Pages deployment
|
|
since this didn't make the cut for 10.10, any plans to add it in 10.11 ? |
|
Thanks for your patience @TheMelmacian! I will see if our UI/UX lead has feedback. |
|
Sorry again for the delay on this. I reviewed the change with our ui/ux lead and I think we are going to hold off and add this functionality as part of the full redesign effort. |
|
As long as the redesign is planned for the next major release, I have no problem with that. |
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
|
Changes
I added a selection menu to the OSD which allows to directly select a chapter.
It shows the number, chapter name and the start time.
If no name is set, a name in the form
Chapter 01is generated.Th currently active chapter is calculated based on playtime and chapter start/end times and shown in the menu.
To prevent the volume from changing when scrolling through the menu, the mouse wheel listener is deactivated while the menu is visible.Edit: This was fixed with #5401, so I adjusted my code accordingly.
For the button I used the ordered list icon:
