Skip to content

Commit 569cf25

Browse files
authored
Remove configuration file for Notebook server in server extension (#246)
1 parent eba1de1 commit 569cf25

File tree

3 files changed

+1
-19
lines changed

3 files changed

+1
-19
lines changed

server-extension/README.md

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -615,7 +615,6 @@ exclude = [".github", "binder"]
615615
"jupyterlab_examples_server/labextension" = "share/jupyter/labextensions/@jupyterlab-examples/server-extension"
616616
"install.json" = "share/jupyter/labextensions/@jupyterlab-examples/server-extension/install.json"
617617
"jupyter-config/server-config" = "etc/jupyter/jupyter_server_config.d"
618-
"jupyter-config/nb-config" = "etc/jupyter/jupyter_notebook_config.d"
619618
620619
[tool.hatch.build.hooks.version]
621620
path = "jupyterlab_examples_server/_version.py"
@@ -659,7 +658,7 @@ It will build the frontend NPM package through its _factory_, and will ensure on
659658
generated files is `jupyterlab_examples_server/labextension/package.json`:
660659

661660
```py
662-
# pyproject.toml#L57-L68
661+
# pyproject.toml#L56-L67
663662

664663
[tool.hatch.build.hooks.jupyter-builder]
665664
dependencies = ["hatch-jupyter-builder>=0.5"]
@@ -711,15 +710,6 @@ in the appropriate jupyter folder (`etc/jupyter/jupyter_server_config.d`):
711710
"jupyter-config/server-config" = "etc/jupyter/jupyter_server_config.d"
712711
```
713712

714-
For backward compatibility with the classical notebook, the old version of that file is copied in
715-
(`etc/jupyter/jupyter_notebook_config.d`):
716-
717-
```py
718-
# pyproject.toml#L52-L52
719-
720-
"jupyter-config/nb-config" = "etc/jupyter/jupyter_notebook_config.d"
721-
```
722-
723713
### JupyterLab Extension Manager
724714

725715
The distribution as a Python package has been described in the previous subsection. But

server-extension/jupyter-config/nb-config/jupyterlab_examples_server.json

Lines changed: 0 additions & 7 deletions
This file was deleted.

server-extension/pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ exclude = [".github", "binder"]
4949
"jupyterlab_examples_server/labextension" = "share/jupyter/labextensions/@jupyterlab-examples/server-extension"
5050
"install.json" = "share/jupyter/labextensions/@jupyterlab-examples/server-extension/install.json"
5151
"jupyter-config/server-config" = "etc/jupyter/jupyter_server_config.d"
52-
"jupyter-config/nb-config" = "etc/jupyter/jupyter_notebook_config.d"
5352

5453
[tool.hatch.build.hooks.version]
5554
path = "jupyterlab_examples_server/_version.py"

0 commit comments

Comments
 (0)