Make Tests for ArbitrablePermissionList

[clesaege]

https://github.com/kleros/kleros-interaction/blob/master/contracts/standard/permission/ArbitrablePermissionList.sol

[heypran]

I am interested in taking this up..
started working on this

[heypran]

What is the significance of the item that we are trying to register?

[heypran]

I have a doubt it in the below scenario -

    /**
     *  @dev Appeal ruling. Anyone can appeal to prevent a malicious actor from challenging its own submission and losing on purpose.
     *  @param _value The value of the item with the dispute to appeal on.
     */
    function appeal(bytes32 _value) public payable {
        Item storage item = items[_value];
        arbitrator.appeal.value(msg.value)(item.disputeID,arbitratorExtraData); // Appeal, no need to check anything as the arbitrator does it.
    }

The scenario says that appeal can be made to prevent a malicious actor from challenging its own submission and losing on purpose.
Suggestion: This can be prevented by adding a require(item.submitter !=msg.sender) in the challenge functions

[epiqueras]

He could just make a second account to bypass that.

…

On Sun, Oct 28, 2018 at 2:29 PM heychessy ***@***.***> wrote: I have a doubt it in the below scenario - /** * @dev Appeal ruling. Anyone can appeal to prevent a malicious actor from challenging its own submission and losing on purpose. * @param _value The value of the item with the dispute to appeal on. */ function appeal(bytes32 _value) public payable { Item storage item = items[_value]; arbitrator.appeal.value(msg.value)(item.disputeID,arbitratorExtraData); // Appeal, no need to check anything as the arbitrator does it. } The scenario says that appeal can be made to prevent a malicious actor from challenging its own submission and losing on purpose. Suggestion: This can be prevented by adding a require(item.submitter !=msg.sender) in the challenge functions — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#139 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ASRQaGunaCC0kBaXyAnipTirVwJ_dl7Gks5upbErgaJpZM4XOFTM> .

[heypran]

How should I submit the test code?

[epiqueras]

Through a pull request. But I think @mtsalenc was already working on this?

[heypran]

I have submitted a pull request #164, request a review.