$client->listDir throws Exception when there is no file in remote directory

[terrylinooo]

Lazzard\FtpClient\Exception\FtpClientException: [FtpClientException] - Failed to get files list.

I found that there would be at least one file in that directory will work.

Expected:

Return empty array instead.

[AmraniCh]

Hi, Thanks for opening this issue.

Actually, this exception is thrown when calling the native function `ftp_nlst ``and it is returned false, the exception message that you've got is means that the native function just fails without raising any error, because if the error raised the library can catch this error message and throws exceptions with them.

public function listDir($directory, $filter = self::FILE_DIR_TYPE, $ignoreDots = true)
{
    if (!$files = $this->wrapper->nlist($directory)) {
        throw new FtpClientException($this->wrapper->getErrorMessage()
            ?: "Failed to get files list.");
    }
}

You have to know that FTP servers can haves different implementation of the FTP protocol specification, therefore getting an error should not necessary means you code is wrong, it just a "compatibility issues".

I've tested this method with my own FTP account and the directory was empty, and it works it returns an empty array.

If you want to debug your FTP server and know the exact FTP reply when sending the nlst command, you can use a tool that I've built FTP Bridge.

[betsmoraes]

Hi, im facing same issue.
This is result of FTP bridge debug:

Array
(
[0] => <-- 220-Welcome to cc-ftpd.
220-You are user number 1 of 50 allowed.
220-Local time is now 15:27. Server port: 21.
220-This is a private system - No anonymous login
220-IPv6 connections are also welcome on this server.
220 You will be disconnected after 15 minutes of inactivity.
[1] => --> USER ****
[2] => <-- 331 User OK. Password required
[3] => --> PASS ****
[4] => <-- 230-OK. Current restricted directory is /
230 2720217 Kbytes used (53%) - authorized: 5120000 Kb
[5] => --> PWD
[6] => <-- 257 "/" is your current location
[7] => --> PASV
[8] => <-- 227 Entering Passive Mode ()
[9] => --> NLST .
[10] => <-- 150 Accepted data connection
[11] => <-- media
ondemand
playlist.txt
sounds
[12] => <-- 226 4 matches total
[13] => --> QUIT
[14] => <-- 221-Goodbye. You uploaded 0 and downloaded 0 kbytes.
221 Logout.
)

How fix that ?
did not quite understand. :/

[AmraniCh]

@betsmoraes Please try with this code and tell me if you get the same error :

$conn = @ftp_connect($host);

if (!is_resource($conn)) {
    die('Connection failed to the server.');
}

$login = @ftp_login($conn, $username, $password);

if (!$login) {
    die('Logging failed to the server.');
}

ftp_pasv($conn, true);

print_r(@ftp_nlist($conn, $dir));

[AmraniCh]

I think the problem is some FTP servers do not send the DOTS files ('.', '..') when listing the files, so if a directory is empty then the ftp_nlst will return en empty array. The solution is to check for the false value with !== and not with ! operator :

if (($files = $this->wrapper->nlist($directory)) !== false) {
    throw new FtpClientException($this->wrapper->getErrorMessage()
        ?: "Failed to get files list.");
}

[betsmoraes]

Hi @AmraniCh , follow:

@betsmoraes Please try with this code and tell me if you get the same error :

$conn = @ftp_connect($host);

if (!is_resource($conn)) {
    die('Connection failed to the server.');
}

$login = @ftp_login($conn, $username, $password);

if (!$login) {
    die('Logging failed to the server.');
}

ftp_pasv($conn, true);

print_r(@ftp_nlist($conn, $dir));

Returns connection successfull:
Array ( [0] => media [1] => ondemand [2] => playlist.txt [3] => sounds )

I think the problem is some FTP servers do not send the DOTS files ('.', '..') when listing the files, so if a directory is empty then the ftp_nlst will return en empty array. The solution is to check for the false value with !== and not with ! operator :

if (($files = $this->wrapper->nlist($directory)) !== false) {
    throw new FtpClientException($this->wrapper->getErrorMessage()
        ?: "Failed to get files list.");
}

Changing to this, return same error: [FtpClientException] - Failed to get files list.
This changes makes fail another classes too. with same error.

Thank you!

[AmraniCh]

Fixed in #18. A new release will published soon. Thanks for your contrubution @betsmoraes @terrylinooo

[AmraniCh]

Version 1.4.1 is just released.