Skip to content

Commit 3a9262a

Browse files
committed
chore(web): fix failing tests
1 parent 40db204 commit 3a9262a

File tree

2 files changed

+14
-13
lines changed

2 files changed

+14
-13
lines changed

apps/web/app/utils/post-link.test.ts

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,26 +2,23 @@ import { getPostHref } from './post-link';
22

33
describe('getPostHref', () => {
44
it('returns correct URL for valid slug', () => {
5-
const expected =
6-
process.env.NODE_ENV === 'development'
7-
? 'https://prosperous-combination-099461.framer.app/posts/test-slug'
8-
: 'https://leather.io/posts/test-slug';
5+
const expected = import.meta.env.DEV
6+
? 'https://prosperous-combination-099461.framer.app/posts/test-slug'
7+
: 'https://leather.io/posts/test-slug';
98
expect(getPostHref('test-slug')).toBe(expected);
109
});
1110

1211
it('handles empty slug gracefully', () => {
13-
const expected =
14-
process.env.NODE_ENV === 'development'
15-
? 'https://prosperous-combination-099461.framer.app/posts/'
16-
: 'https://leather.io/posts/';
12+
const expected = import.meta.env.DEV
13+
? 'https://prosperous-combination-099461.framer.app/posts/'
14+
: 'https://leather.io/posts/';
1715
expect(getPostHref('')).toBe(expected);
1816
});
1917

2018
it('handles undefined slug gracefully', () => {
21-
const expected =
22-
process.env.NODE_ENV === 'development'
23-
? 'https://prosperous-combination-099461.framer.app/posts/undefined'
24-
: 'https://leather.io/posts/undefined';
19+
const expected = import.meta.env.DEV
20+
? 'https://prosperous-combination-099461.framer.app/posts/undefined'
21+
: 'https://leather.io/posts/undefined';
2522
expect(getPostHref(undefined as any)).toBe(expected);
2623
});
2724
});

apps/web/app/utils/post-link.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
1-
export function getPostHref(slug: string) {
1+
export function getPostHref(slug?: string) {
2+
if (slug === undefined || slug === null) {
3+
slug = 'undefined';
4+
}
5+
26
const trimmedSlug = slug.trim();
37

48
if (URL.canParse(trimmedSlug)) {

0 commit comments

Comments
 (0)