Skip to content

Make linear frontend consistent with mel #77

@auroracramer

Description

@auroracramer

The linear frequency spectrogram frontend results in 197 frames instead of 199, which seems to be caused by:

  • In _librosa_linear_frontend (openl3/core.py), center=False should be center=True when calling librosa.stft
  • In _construct_linear_audio_network (openl3/models.py), pad_end=True should be added to argument for __fix_kapre_spec
  • In _construct_linear_audio_network (openl3/models.py), in the else block corresponding to if include_frontend, the input_shape should account for centering

In addition to fixing these, we'll need to regenerate the regression data likely

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions