Fix query filter (#14836)

Author: NicolasGorga

.changeset/modern-tires-melt.md

@@ -0,0 +1,5 @@
+---
+"@medusajs/core-flows": patch
+---
+
+fix(core-flows): ensure reason ids is an array in `validateReturnReasons` util

integration-tests/http/__tests__/returns/returns.spec.ts

@@ -2,29 +2,36 @@ import { medusaIntegrationTestRunner } from "@medusajs/test-utils"
 import {
   ContainerRegistrationKeys,
   Modules,
+  ReturnStatus,
   RuleOperator,
 } from "@medusajs/utils"
 import {
   adminHeaders,
   createAdminUser,
+  generatePublishableKey,
+  generateStoreHeaders,
 } from "../../../helpers/create-admin-user"
 
 jest.setTimeout(60000)
 
 medusaIntegrationTestRunner({
   testSuite: ({ dbConnection, getContainer, api }) => {
-    let order, order2
+    let order, order2, storeOrder
     let returnShippingOption
     let shippingProfile
     let fulfillmentSet
-    let returnReason
+    let returnReason, returnReasonTwo
     let inventoryItem
     let location
+    let storeHeaders
 
     beforeEach(async () => {
       const container = getContainer()
       await createAdminUser(dbConnection, adminHeaders, container)
 
+      const publishableKey = await generatePublishableKey(container)
+      storeHeaders = generateStoreHeaders({ publishableKey })
+
       shippingProfile = (
         await api.post(
           `/admin/shipping-profiles`,
@@ -73,6 +80,18 @@ medusaIntegrationTestRunner({
         )
       ).data.return_reason
 
+      returnReasonTwo = (
+        await api.post(
+          "/admin/return-reasons",
+          {
+            value: "return-reason-test-two",
+            label: "Test return reason two",
+            description: "This is the reason description!!!",
+          },
+          adminHeaders
+        )
+      ).data.return_reason
+
       const orderModule = container.resolve(Modules.ORDER)
 
       order = await orderModule.createOrders({
@@ -313,7 +332,7 @@ medusaIntegrationTestRunner({
       )
     })
 
-    describe("Returns lifecycle", () => {
+    describe("Admin Returns lifecycle", () => {
       it("Full flow with 2 orders", async () => {
         let result = await api.post(
           "/admin/returns",
@@ -1346,5 +1365,63 @@ medusaIntegrationTestRunner({
         })
       })
     })
+
+    describe("Store Returns lifecycle", () => {
+      it("should request a return", async () => {
+        const createdReturn = (
+          await api.post(
+            "/store/returns",
+            {
+              order_id: order.id,
+              items: [
+                {
+                  id: order.items[0].id,
+                  quantity: 1,
+                  reason_id: returnReason.id,
+                },
+                {
+                  id: order.items[0].id,
+                  quantity: 1,
+                  reason_id: returnReasonTwo.id,
+                },
+              ],
+              return_shipping: {
+                option_id: returnShippingOption.id,
+              },
+            },
+            storeHeaders
+          )
+        ).data.return
+
+        expect(createdReturn).toEqual(
+          expect.objectContaining({
+            id: expect.any(String),
+            order_id: order.id,
+            status: ReturnStatus.REQUESTED,
+            items: expect.arrayContaining([
+              expect.objectContaining({
+                id: expect.any(String),
+                item_id: order.items[0].id,
+                quantity: 1,
+                reason_id: returnReason.id,
+              }),
+              expect.objectContaining({
+                id: expect.any(String),
+                item_id: order.items[0].id,
+                quantity: 1,
+                reason_id: returnReasonTwo.id,
+              }),
+            ]),
+            shipping_methods: expect.arrayContaining([
+              expect.objectContaining({
+                id: expect.any(String),
+                shipping_option_id: returnShippingOption.id,
+                name: returnShippingOption.name,
+              }),
+            ]),
+          })
+        )
+      })
+    })
   },
 })

packages/core/core-flows/src/order/utils/validate-return-reason.ts

@@ -30,7 +30,7 @@ export async function validateReturnReasons(
       "parent_return_reason",
       "return_reason_children.id",
     ],
-    variables: { id: [inputItems.map((item) => item.reason_id)], limit: null },
+    variables: { id: inputItems.map((item) => item.reason_id), limit: null },
   })
 
   const returnReasons = await remoteQuery(remoteQueryObject)