Posthog Analytic Idenfier method

[teeliny]

Investigation

After checking the implementation, I noticed that the identify method is always throwing the error, regardless of whether actor_id or group is provided.

Current Implementation

async identify(data) {
  if ("group" in data) {
    this.client_.groupIdentify({
      groupKey: data.group.id,
      groupType: data.group.type,
      properties: data.properties,
      distinctId: data.actor_id,
    });
  } else if (data.actor_id) {
    this.client_.identify({
      distinctId: data.actor_id,
      properties: data.properties,
    });
  }

  throw new Error(
    "Actor or group is required when identifying an entity with Posthog"
  );
}

Stack Trace
Error: Actor or group is required when identifying an entity with Posthog
at PosthogAnalyticsService.identify (/repo-directory/node_modules/@medusajs/analytics-posthog/src/services/posthog-analytics.ts:81:11)
at AnalyticsProviderService.identify (/repo-directory/node_modules/@medusajs/analytics/src/services/provider-service.ts:50:29)
at PostHogAnalytics.identify (/repo-directory/src/utils/posthog-analytics.ts:70:44)
at postHogAuthTrackingHandler (/repo-directory/src/subscribers/posthog-auth-tracking.ts:67:27)
at processTicksAndRejections (node:internal/process/task_queues:105:5)
at async subscriber (/repo-directory/node_modules/@medusajs/framework/src/subscribers/subscriber-loader.ts:168:16)
at async EventEmitter.<anonymous> (/repo-directory/node_modules/@medusajs/event-bus-local/src/services/event-bus-local.ts:146:9)

[sunnypatell]

@teeliny this is a confirmed bug in the @medusajs/analytics-posthog package. the throw new Error(...) was placed outside the if/else blocks, so it fires unconditionally after every identify or groupIdentify call regardless of whether a valid actor_id or group was provided.

it was fixed in PR #14562 (merged jan 18) and shipped in v2.13.0. upgrading to >=2.13.0 resolves it.

the corrected code now looks like:

async identify(data) {
  if ("group" in data) {
    this.client_.groupIdentify({ ... });
  } else if (data.actor_id) {
    this.client_.identify({ ... });
  } else {
    throw new Error("Actor or group is required...");
  }
}

the throw is now inside the else branch where it belongs, so it only fires when neither an actor nor group is provided.

ref: medusa v2.13.0 release notes