fix: correctly detect suffix for scoped packages with dots (#323)

Author: rasimx

src/utils/VirtualModule.ts

@@ -1,5 +1,5 @@
 import { existsSync, mkdirSync, writeFile, writeFileSync } from 'fs';
-import { dirname, join, parse, resolve } from 'pathe';
+import { dirname, join, parse, resolve, basename } from 'pathe';
 import { packageNameDecode, packageNameEncode } from '../utils/packageNameUtils';
 import { getNormalizeModuleFederationOptions } from './normalizeModuleFederationOptions';
 
@@ -30,6 +30,17 @@ function getNodeModulesDir() {
   return cachedNodeModulesDir;
 }
 
+export function getSuffix(name: string): string {
+  const base = basename(name);
+  const dotIndex = base.lastIndexOf('.');
+
+  if (dotIndex > 0 && dotIndex < base.length - 1) {
+    return base.slice(dotIndex);
+  }
+
+  return '.js';
+}
+
 const patternMap: {
   [tag: string]: RegExp;
 } = {};
@@ -92,7 +103,7 @@ export default class VirtualModule {
   constructor(name: string, tag: string = '__mf_v__', suffix = '') {
     this.name = name;
     this.tag = tag;
-    this.suffix = suffix || name.split('.').slice(1).pop()?.replace(/(.)/, '.$1') || '.js';
+    this.suffix = suffix || getSuffix(name);
     if (!cacheMap[this.tag]) cacheMap[this.tag] = {};
     cacheMap[this.tag][this.name] = this;
   }

src/utils/__tests__/VirtualModule.test.ts

@@ -0,0 +1,39 @@
+import { getSuffix } from '../VirtualModule';
+
+describe('getSuffix', () => {
+  it('returns .js for simple package without extension', () => {
+    expect(getSuffix('react')).toBe('.js');
+  });
+
+  it('returns .js for scoped package without extension', () => {
+    expect(getSuffix('@scope/pkg')).toBe('.js');
+  });
+
+  it('returns .js for scoped package with dots in namespace but no file', () => {
+    expect(getSuffix('@company.name/pkg')).toBe('.js');
+  });
+
+  it('detects correct suffix for file with extension', () => {
+    expect(getSuffix('some/path/to/module.ts')).toBe('.ts');
+  });
+
+  it('detects correct suffix for scoped package with nested file and extension', () => {
+    expect(getSuffix('@scope/pkg/sub/file.jsx')).toBe('.jsx');
+  });
+
+  it('handles scoped package with dots in namespace and extension in file', () => {
+    expect(getSuffix('@company.name/pkg/utils/helper.tsx')).toBe('.tsx');
+  });
+
+  it('returns .js if dot is before namespace', () => {
+    expect(getSuffix('.bin/@scope/pkg')).toBe('.js');
+  });
+
+  it('returns correct suffix when multiple dots after namespace', () => {
+    expect(getSuffix('@scope/pkg/path.to/module.name.mjs')).toBe('.mjs');
+  });
+
+  it('returns correct suffix for deep relative path with scoped namespace', () => {
+    expect(getSuffix('@scope.with.dots/pkg/deep/util.spec.ts')).toBe('.ts');
+  });
+});