DSL refactor and minor Ruby improvements and fixes (#8)

* Moved DSL classes to separate files

* Backport `yield_self` and replace `derp`

* Moved param-related classes into `TLAW::Params` namespace

* Move `TLAW::Params::Param#make` to `TLAW::Params#make`

`Param` shouldn’t have to know about subclasses

* Update gem info

* Require Ruby 2.3.0+

* Rename `Params::Param` to `Params::Base`

* Require `backports` gem

* Changed style back to `fetch -> validate -> create`

* Invert logic

* Bring back "GET-only APIs" wording

* Moved DSL comments to  module

* Fix Rubocop issues

* Fix path to TLAW gem for examples

* Fix example

* Fix nil check

* Revert docs

* Fixed Rubocop warnings

* Fix Rubocop errors for latest Rubocop version

* Expand path to run examples from parent directory

* Removed duplicate docs from cherry-pick

* Replaced TODO with some dummy docs

Author: joelvh

.rubocop.yml

@@ -2,6 +2,7 @@ inherit_from: .rubocop_todo.yml
 require: rubocop-rspec
 
 AllCops:
+  TargetRubyVersion: 2.3.0
   Include:
     - 'lib/**/*'
   Exclude:
@@ -13,6 +14,10 @@ AllCops:
     - 'Gemfile'
   DisplayCopNames: true
 
+# Ruby 2.3+
+FrozenStringLiteralComment:
+  Enabled: false
+
 # My personal style
 # -----------------
 

.ruby-version

@@ -0,0 +1 @@
+2.3.0

.travis.yml

@@ -1,10 +1,9 @@
 cache: bundler
 language: ruby
 rvm:
-  - "2.1"
-  - "2.2"
   - "2.3"
   - "2.4"
+  - "2.5"
   - jruby-9.1.13.0
 install:
   - bundle install --retry=3

Gemfile

@@ -4,5 +4,5 @@ gemspec
 
 group :test do
   gem 'coveralls', require: false
-  gem 'saharspec', '= 0.0.4'
+  gem 'saharspec', '0.0.4'
 end

README.md

@@ -4,9 +4,9 @@
 [![Build Status](https://travis-ci.org/molybdenum-99/tlaw.svg?branch=master)](https://travis-ci.org/molybdenum-99/tlaw)
 [![Coverage Status](https://coveralls.io/repos/molybdenum-99/tlaw/badge.svg?branch=master)](https://coveralls.io/r/molybdenum-99/tlaw?branch=master)
 
-**TLAW** (pronounce it like "tea+love"... or whatever) is the last (and
-only) API wrapper framework for _get-only APIes_<sup>[*](#get-only-api)</sup>
-(think weather, search, economical indicators, geonames and so on).
+**TLAW** (pronounce it like "tea+love"... or whatever) is the last (and only)
+API wrapper framework you'll ever need for accessing _GET-only APIs_<sup>[*](#get-only-api)</sup>
+in a consistent way (think weather, search, economical indicators, geonames and so on).
 
 ## Table Of Contents
 
@@ -302,7 +302,7 @@ post_process_items('foo') {
 
 # More realistic examples:
 post_process('meta.count', &:to_i)
-post_process('daily') {
+post_process_items('daily') {
   post_process('date', &Date.method(:parse))
 }
 post_process('auxiliary_value') { nil } # Nil's will be thrown away completely
@@ -314,9 +314,9 @@ See full post-processing features descriptions in
 #### All at once
 
 All described response processing steps are performed in this order:
+
 * parsing and initial flattening of JSON (or XML) hash;
-* applying post-processors (and flatten the response after _each_ of
-  them);
+* applying post-processors (and flatten the response after _each_ of them);
 * make `DataTable`s from arrays of hashes.
 
 ### Documentability

Rakefile

@@ -3,7 +3,7 @@ require 'rubygems/tasks'
 Gem::Tasks.new
 
 namespace :doc do
-  desc "Prints TOC for README.md (doesn't inserts it automatically!)"
+  desc "Prints TOC for README.md (doesn't insert it automatically!)"
   task :toc do
     # NB: really dumb. Yet better than any Solution I can find :(
     # Grabbing it from project to project.

examples/demo_base.rb

@@ -1,7 +1,7 @@
-require 'pp'
+$:.unshift File.expand_path('../../lib', __FILE__)
 
-$:.unshift 'lib'
 require 'tlaw'
+require 'pp'
 
 begin
   require 'dotenv'

lib/tlaw.rb

@@ -1,20 +1,9 @@
+require 'backports/2.5.0/kernel/yield_self'
 require 'open-uri'
 require 'json'
 require 'addressable/uri'
 require 'addressable/template'
 
-# Let no one know! But they in Ruby committee just too long to add
-# something like this to the language.
-#
-# See also https://bugs.ruby-lang.org/issues/12760
-#
-# @private
-class Object
-  def derp
-    yield self
-  end
-end
-
 # TLAW is a framework for creating API wrappers for get-only APIs (like
 # weather, geonames and so on) or subsets of APIs (like getting data from
 # Twitter).
@@ -55,8 +44,7 @@ module TLAW
 require_relative 'tlaw/util'
 require_relative 'tlaw/data_table'
 
-require_relative 'tlaw/param'
-require_relative 'tlaw/param_set'
+require_relative 'tlaw/params'
 
 require_relative 'tlaw/api_path'
 require_relative 'tlaw/endpoint'

lib/tlaw/api_path.rb

@@ -1,3 +1,4 @@
+require_relative 'params/set'
 require 'forwardable'
 
 module TLAW
@@ -54,7 +55,7 @@ def inherit(namespace, **attrs)
 
       # @private
       def params_from_path!
-        Addressable::Template.new(path).keys.each do |key| # rubocop:disable Performance/HashEachMethods
+        Addressable::Template.new(path).keys.each do |key|
           param_set.add key.to_sym, keyword: false
         end
       end
@@ -67,13 +68,13 @@ def setup_parents(parent)
 
       # @private
       def symbol=(sym)
-        @symbol = sym
         @path ||= "/#{sym}"
+        @symbol = sym
       end
 
-      # @return [ParamSet]
+      # @return [Params::Set]
       def param_set
-        @param_set ||= ParamSet.new
+        @param_set ||= Params::Set.new
       end
 
       # @private

lib/tlaw/data_table.rb

@@ -109,8 +109,8 @@ def inspect
     end
 
     # @private
-    def pretty_print(pp)
-      pp.text("#<#{self.class.name}[#{keys.join(', ')}] x #{size}>")
+    def pretty_print(printer)
+      printer.text("#<#{self.class.name}[#{keys.join(', ')}] x #{size}>")
     end
   end
 end