Skip to content

Commit 20cf810

Browse files
authored
bug: Do not set the `GOOGLE_APPLICATION_CREDENTIALS in the reliability docker image (#984)
I'm getting a credential error with this, because I believe that the credentials are not being found. Going to remove this to see if there's a default set that is passed to the docker image.
1 parent 4175c21 commit 20cf810

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

scripts/reliability/Dockerfile

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,8 @@ WORKDIR /app
77
# should this be templated? Some have a path here I presume gets loaded via a Docker build.
88
# (e.g. fxa uses `/app/keys/keyfile_name.json`)
99
# loaded va the webservices-infra cronjob.yaml:: containers::volumeMounts
10-
VOLUME [ "keys" "/app/keys" ]
11-
ENV GOOGLE_APPLICATION_CREDENTIALS = /app/keys/service-account-key.json
12-
13-
# these will need to be templated in the calling k8s config.
14-
# ENV AUTOEND__DB_SETTINGS = '{"table_name":"projects/test/instance/test/tables/autopush"}'
15-
# ENV AUTOEND__DB_DSN = "grpc:://localhost:8086"
16-
# ENV AUTOEND__RELIABILITY_DSN = "redis:://localhost"
10+
# VOLUME [ "keys" "/app/keys" ]
11+
# ENV GOOGLE_APPLICATION_CREDENTIALS = /app/keys/service-account-key.json
1712

1813
# Generate the report
1914
ENV AUTOTRACK_REPORT_BUCKET_NAME = "autopush_reliability"

0 commit comments

Comments
 (0)