feat: remove stage key debugging code (#867)

Author: jrconlin

autoendpoint/src/settings.rs

@@ -222,9 +222,7 @@ impl VapidTracker {
         };
         let result = self.0.contains(&key);
 
-        // The following has been elevated for diagnostic purposes and should be returned as `debug` once
-        // reliability issues are addressed
-        warn!("🔍 Checking {:?} {}", &vapid.public_key, {
+        debug!("🔍 Checking {:?} {}", &vapid.public_key, {
             if result {
                 "Match!"
             } else {

autopush-common/src/util/mod.rs

@@ -47,22 +47,7 @@ pub fn b64_encode_std(input: &Vec<u8>) -> String {
 
 /// Try to decode the string, first as URL safe, then as STD.
 pub fn b64_decode(input: &str) -> Result<Vec<u8>, base64::DecodeError> {
-    // This is very verbose, but for some reason the key on stage is failing.
-    // This code should help identify the cause and should be temporary.
-    match b64_decode_url(input) {
-        Ok(v) => Ok(v),
-        Err(base64::DecodeError::InvalidByte(pos, chr)) => {
-            warn!(
-                "Decode: invalid byte {:?} at {} in {:?}",
-                chr as char, pos, input
-            );
-            b64_decode_std(input)
-        }
-        Err(e) => {
-            warn!("Decode: Unexpected error {:?} for {:?}", &e, input);
-            Err(e)
-        }
-    }
+    b64_decode_url(input).or_else(|_| b64_decode_std(input))
 }
 
 pub fn deserialize_u32_to_duration<'de, D>(deserializer: D) -> Result<Duration, D::Error>