Do not automatically restart NM after static configuration

nicksinger · nicksinger · commit 3168a10eec8a · 2024-11-11T12:19:48.000+01:00
NM changes happen at runtime and automatically restarting it just wastes time and introduces more options to fail without providing any benefit. Related issue: https://progress.opensuse.org/issues/169531
diff --git a/lib/mm_network.pm b/lib/mm_network.pm
@@ -228,7 +228,7 @@ sub setup_static_mm_network {
     configure_static_ip(ip => $ip, is_nm => $is_nm);
     configure_default_gateway(is_nm => $is_nm);
     configure_static_dns(get_host_resolv_conf(), is_nm => $is_nm);
-    restart_networking(is_nm => $is_nm);
+    restart_networking(is_nm => $is_nm) unless $is_nm;
 }
 
 sub restart_networking {

Original file line number	Diff line number	Diff line change
`@@ -228,7 +228,7 @@ sub setup_static_mm_network {`
`228`	`228`	`configure_static_ip(ip => $ip, is_nm => $is_nm);`
`229`	`229`	`configure_default_gateway(is_nm => $is_nm);`
`230`	`230`	`configure_static_dns(get_host_resolv_conf(), is_nm => $is_nm);`
`231`		`- restart_networking(is_nm => $is_nm);`
	`231`	`+ restart_networking(is_nm => $is_nm) unless $is_nm;`
`232`	`232`	`}`
`233`	`233`
`234`	`234`	`sub restart_networking {`