Changing an addon to be hosted mode does not delete old ManifestWork

[mprahl]

If I define a ManagedClusterAddOn like this:

apiVersion: addon.open-cluster-management.io/v1alpha1
kind: ManagedClusterAddOn
metadata:
  name: config-policy-controller
  namespace: cluster2
spec:
  installNamespace: cluster2-grc

Then change it to hosted mode:

apiVersion: addon.open-cluster-management.io/v1alpha1
kind: ManagedClusterAddOn
metadata:
  annotations:
    addon.open-cluster-management.io/hosting-cluster-name: cluster1
  name: config-policy-controller
  namespace: cluster2
spec:
  installNamespace: cluster2-grc

The ManifestWork for both deployment types remain:

❯ kubectl get manifestwork -A
NAMESPACE   NAME                                                       AGE
cluster1    addon-config-policy-controller-deploy-hosting-cluster2-0   3m18s
cluster2    addon-config-policy-controller-deploy-0                    10m

[qiujian16]

@zhujian7 I think it should have been fixed?

[zhujian7]

Hi @qiujian16 I don't think we currently support install mode switching, do we need to support it? if we do, I will investigate further.

[qiujian16]

I see, yeah, we probably should doc that we do not support such case somewhere.