deleteOption not set on ManifestWork created from ManagedClusterAddOn/AddOnTemplate

[arturshadnik]

I noticed that the AddOnTemplateSpec.AgentSpec supports the entire workv1.ManifestWorkSpec, including DeleteOption, but the only field that is propagated to the ManifestWork is Manifests (i believe it's this code https://github.com/open-cluster-management-io/addon-framework/blob/main/pkg/addonmanager/controllers/agentdeploy/utils.go#L96). Was there a reason behind this decision?

We have a usecase in fleetconfig-controller where we would like to skip garbage collection of 1 addon's resources when a ManagedCluster is deleted, but there currently doesnt seem to be a way to do this when using an AddOnTemplate.

Thoughts on supporting setting all of the supported fields of AddOnTemplateSpec.AgentSpec when creating the AddOns ManifestWork? Happy to work on this, just looking to get an idea for why it was omitted in the first place 🙂

[zhujian7]

Hi @arturshadnik thank you for reporting this issue, currently propagating the DeleteOption in the AddonTemplate to the ManifestWork is not supported, but for your requirement, there is an alternative way: add the annotation addon.open-cluster-management.io/addon-pre-delete to the resource that you want to orphan like this. I am trying to add a doc for this.
cc @zhiweiyin318

why it was omitted in the first place

We did not intend to omit other fields, but just lack bandwidth, the addon template code is here, super welcome if you'd like to enhance this.

[arturshadnik]

Thank you @zhujian7! I'll try the annotation. I also found taints on the ManagedCluster accomplished what I needed. I'll look into adding support for the other fields.

[thibaultmg]

Hello, just went into this. I'm also having this need for deploying CRDs that might be common to another operator.
I use the server-side apply update strategy, but when the manifestWork is removed, the work agent deletes the resource, even if it is not its controller.
I'll use the annotation in the meantime. Thanks!