Skip to content

bindings: python check in configury needs to be improved #13242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hppritcha opened this issue May 8, 2025 · 1 comment · Fixed by #13248
Closed

bindings: python check in configury needs to be improved #13242

hppritcha opened this issue May 8, 2025 · 1 comment · Fixed by #13248
Assignees

Comments

@hppritcha
Copy link
Member

There's a check in ompi_configure_options.m4 for python 3.6 or higher to support generation of the top level c and fortran f08 bindings from the code in ompi/mpi/bindings. That's fine, but the file being used as a sentinel to tell whether or not the bindings have already been generated is not correct. the names of the generated files has changed and ompi_send.c is not being generated, rather a differently named file.

@hppritcha hppritcha self-assigned this May 8, 2025
@jsquyres
Copy link
Member

jsquyres commented May 8, 2025

I also think we probably need an explicit check in OMPI's configure for Python. At the moment, we have a Sphinx setup macro which requires python, that's only if you're building the docs (which obviously is optional).

Also right now, the only python required for a tarball build is for the Fortran MPI bindings (per #13231). So we could protect the python check behind a few things:

  • if you're building the fortran MPI bindings, or
  • if you're in a git clone that doesn't have various sentinel files, etc., or
  • ...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants