Show node where command is executed first (srl-labs#2503)

* display node where command is executed first

* link symbol

* fix token positions in the tests

* keyword fix

Author: hellt

clab/exec/exec.go

@@ -262,8 +262,8 @@ func (ec *ExecCollection) Log() {
 			default:
 				log.Info(
 					"Executed command",
-					"command", er.GetCmdString(),
 					"node", k,
+					"command", er.GetCmdString(),
 					"stdout", er.GetStdOutString(),
 				)
 			}

links/link_veth.go

@@ -195,7 +195,7 @@ func (l *LinkVEth) deployBEnd(ctx context.Context, idx int) error {
 	l.DeploymentState = LinkDeploymentStateFullDeployed
 
 	if len(l.Endpoints) == 2 {
-		log.Infof("Created link: %s <--> %s", l.Endpoints[0], l.Endpoints[1])
+		log.Infof("Created link: %s ▪┄┄▪ %s", l.Endpoints[0], l.Endpoints[1])
 	}
 
 	return nil

tests/01-smoke/01-basic-flow.robot

@@ -18,15 +18,15 @@ ${n2-ipv4}                  172.20.20.100/24
 ${n2-ipv6}                  3fff:172:20:20::100/64
 ${table-delimit}            │
 ${l1-uname-exec-output}     SEPARATOR=\n
-...                         Executed command command="uname -n" node=clab-2-linux-nodes-l1
+...                         Executed command node=clab-2-linux-nodes-l1 command="uname -n"
 ...                         ${SPACE}${SPACE}stdout=
 ...                         ${SPACE}${SPACE}│ l1
 ${l2-uname-exec-output}     SEPARATOR=\n
-...                         Executed command command="uname -n" node=clab-2-linux-nodes-l2
+...                         Executed command node=clab-2-linux-nodes-l2 command="uname -n"
 ...                         ${SPACE}${SPACE}stdout=
 ...                         ${SPACE}${SPACE}│ l2
 ${l3-uname-exec-output}     SEPARATOR=\n
-...                         Executed command command="uname -n" node=clab-2-linux-nodes-l3
+...                         Executed command node=clab-2-linux-nodes-l3 command="uname -n"
 ...                         ${SPACE}${SPACE}stdout=
 ...                         ${SPACE}${SPACE}│ l3
 

tests/01-smoke/18-stages.robot

@@ -15,11 +15,11 @@ ${lab-file}                     stages.clab.yml
 ${lab-name}                     stages
 ${runtime}                      docker
 ${n4-exec-output}               SEPARATOR=\n
-...                             Executed command command="uname -n" node=node4
+...                             Executed command node=node4 command="uname -n"
 ...                             ${SPACE}${SPACE}stdout=
 ...                             ${SPACE}${SPACE}│ node4
 ${n4-exec-healthy-output}       SEPARATOR=\n
-...                             Executed command command="echo hey I am exiting healthy stage" node=node4
+...                             Executed command node=node4 command="echo hey I am exiting healthy stage"
 ...                             ${SPACE}${SPACE}stdout=
 ...                             ${SPACE}${SPACE}│ hey I am exiting healthy stage
 
@@ -81,7 +81,7 @@ Ensure node4 executed on-exit commands for its healthy stage
 Ensure node3 executed on-exit commands for its create stage and this output doesn't contain any non eth0/lo interfaces
     ${extracted_text} =    Extract Text Between Markers
     ...    ${deploylog.stderr}
-    ...    INFO Executed command command="ls /sys/class/net/" node=node3
+    ...    INFO Executed command node=node3 command="ls /sys/class/net/"
 
     Log    extracted node3 output is${\n}${extracted_text}    console=${True}
 
@@ -98,7 +98,7 @@ Ensure node3 executed on-exit commands for its create stage and this output does
 Ensure node1 executed on-enter commands for its create-links stage and this output doesn't contain any non eth0/lo interfaces
     ${extracted_text} =    Extract Text Between Markers
     ...    ${deploylog.stderr}
-    ...    INFO Executed command command="ls /sys/class/net/" node=node1
+    ...    INFO Executed command node=node1 command="ls /sys/class/net/"
 
     Log    ${extracted_text}    console=${True}