Skip to content

Invalid char comparison to negative value #32

Open
@sam6258

Description

@sam6258

In tests like test_shmem_zero_get.c, there is an invalid comparison between a char and a negative number.

if (dest8[i] != -9) {

Depending on the architecture's implementation of char, the test could fail. According to The C Programming Language, the implementation of char has implementation defined limits. The portable way to do this would be to use signed char.

Test cases failing on Power PC because of this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions