fix: Modify the search issue after select all blocks #1526
Conversation
WalkthroughA new computed property was introduced to track selected items not present in the current Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
bug
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/common/component/SelectAll.vue (1)
30-32: Consider adding type annotations for better maintainability.While the logic is correct, adding explicit type annotations would improve code maintainability and catch potential type-related issues at compile time.
-const selectNotSearchList = computed(() => - props.selected.filter((item) => !props.allItems.some((i) => item.id === i.id)) -) +const selectNotSearchList = computed<Array<any>>(() => + props.selected.filter((item) => !props.allItems.some((i) => item.id === i.id)) +)Consider defining a proper interface for the item type instead of using
any.Also applies to: 40-45
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/common/component/SelectAll.vue(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: rhlin
PR: opentiny/tiny-engine#1011
File: packages/canvas/render/src/RenderMain.ts:82-88
Timestamp: 2025-01-14T08:50:50.226Z
Learning: For PR #1011, the focus is on resolving conflicts and migrating code, with architectural improvements deferred for future PRs.
packages/common/component/SelectAll.vue (2)
Learnt from: gene9831
PR: opentiny/tiny-engine#1011
File: packages/configurator/src/router-select-configurator/RouterSelectConfigurator.vue:95-98
Timestamp: 2025-01-14T06:55:59.692Z
Learning: The tiny-select component from @opentiny/vue library ensures selected options are valid internally, requiring no additional validation in the change handler.
Learnt from: gene9831
PR: opentiny/tiny-engine#830
File: packages/common/component/MetaChildItem.vue:50-56
Timestamp: 2024-10-15T02:45:17.168Z
Learning: In `packages/common/component/MetaChildItem.vue`, when checking if `text` is an object in the computed property `title`, ensure that `text` is not `null` because `typeof null === 'object'` in JavaScript. Use checks like `text && typeof text === 'object'` to safely handle `null` values.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: push-check
🔇 Additional comments (3)
packages/common/component/SelectAll.vue (3)
30-32: LGTM! Clean implementation of out-of-context selection tracking.The
selectNotSearchListcomputed property correctly identifies items that are selected but not present in the currentallItemslist. This approach effectively handles the scenario where users have selections from previous search results that should be preserved.
42-45: Excellent handling of deselect-all edge case.The conditional logic correctly preserves out-of-context selections when deselecting all visible items. This ensures that selections from previous search results or different contexts are maintained, which aligns perfectly with the PR objective.
40-40: No duplicates possible inselectAllconcatenation
TheselectNotSearchListcomputed property explicitly filters out any item whoseidexists inprops.allItems, so concatenatingprops.allItems.concat(selectNotSearchList.value)cannot introduce duplicates. No changes required.
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
区块添加页面，区块全选后，搜索出来的结果取消全选，会整体取消，当前修改为，只取消搜索出来的选项的，搜索清空后，未搜索到的数据选择正常，不会被取消
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit