fix: gencode faild when previous user dirhandle was deleted

[chilingling]

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

Background and solution

【问题描述】
出码时，如果将前面一次选择授权的文件夹删除了，后面出码会失败

【解决方案】
每次出码前，判断用户的 dirhandle 是否还有效，如果已经失效了，则重新获取授权。

额外：出码成功 Tips 增加出码文件夹（dirHandle.name ）的提示。

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• New Features

  • Enhanced confirmation messages now display the name of the directory where files are saved.

• Bug Fixes

  • Improved reliability when accessing previously selected directories by validating directory access before proceeding.

[coderabbitai]

Walkthrough

An asynchronous function, validateDirHandle, was introduced to verify the validity of the directory handle in state.dirHandle by attempting to iterate over its entries. The getPreGenerateInfo function now uses this validator before requesting a new directory handle. The confirm function's success message now includes the directory name.

Changes

File(s)	Change Summary
packages/toolbars/generate-code/src/Main.vue	Added validateDirHandle async function; updated getPreGenerateInfo to use it; improved success message in confirm to include directory name.

Estimated code review effort

2 (~15 minutes)

Poem

A bunny hopped through code today,
Checking folders, come what may.
If the handle’s good, we leap ahead,
If not, a new path’s fetched instead.
Now with messages clear and bright,
Directory names hop into sight!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2edf50c and a655022.

📒 Files selected for processing (1)

• packages/toolbars/generate-code/src/Main.vue (3 hunks)

🧠 Learnings (2)

📓 Common learnings

Learnt from: gene9831
PR: opentiny/tiny-engine#1041
File: packages/plugins/datasource/src/DataSourceList.vue:138-138
Timestamp: 2025-01-14T10:06:25.508Z
Learning: PR #1041 in opentiny/tiny-engine is specifically for reverting Prettier v3 formatting to v2, without any logical code changes or syntax improvements.

Learnt from: rhlin
PR: opentiny/tiny-engine#1011
File: packages/canvas/render/src/RenderMain.ts:82-88
Timestamp: 2025-01-14T08:50:50.226Z
Learning: For PR #1011, the focus is on resolving conflicts and migrating code, with architectural improvements deferred for future PRs.

packages/toolbars/generate-code/src/Main.vue (4)

Learnt from: yy-wow
PR: #850
File: packages/toolbars/preview/src/Main.vue:16-16
Timestamp: 2024-10-10T02:47:46.239Z
Learning: In packages/toolbars/preview/src/Main.vue, within the preview function, the getMergeMeta method is used at lines 64 and 65 to retrieve engine.config configurations.

Learnt from: yy-wow
PR: #850
File: packages/toolbars/preview/src/Main.vue:0-0
Timestamp: 2024-10-10T02:48:10.881Z
Learning: 在 packages/toolbars/preview/src/Main.vue 文件中，使用 useNotify 而不是 console 来记录错误日志。

Learnt from: yy-wow
PR: #886
File: packages/toolbars/generate-code/src/http.js:37-37
Timestamp: 2024-10-30T02:19:46.574Z
Learning: In packages/toolbars/generate-code/src/http.js, functions like fetchPageList do not perform parameter validation since errors are handled by the caller.

Learnt from: rhlin
PR: #1011
File: packages/canvas/render/src/application-function/global-state.ts:12-25
Timestamp: 2025-01-14T08:45:57.032Z
Learning: The code in packages/canvas/render/src/application-function/global-state.ts is migrated from an existing codebase and should be handled with care when making modifications.

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: gene9831
PR: opentiny/tiny-engine#1041
File: packages/plugins/datasource/src/DataSourceList.vue:138-138
Timestamp: 2025-01-14T10:06:25.508Z
Learning: PR #1041 in opentiny/tiny-engine is specifically for reverting Prettier v3 formatting to v2, without any logical code changes or syntax improvements.

Learnt from: rhlin
PR: opentiny/tiny-engine#1011
File: packages/canvas/render/src/RenderMain.ts:82-88
Timestamp: 2025-01-14T08:50:50.226Z
Learning: For PR #1011, the focus is on resolving conflicts and migrating code, with architectural improvements deferred for future PRs.

packages/toolbars/generate-code/src/Main.vue (4)

Learnt from: yy-wow
PR: #850
File: packages/toolbars/preview/src/Main.vue:16-16
Timestamp: 2024-10-10T02:47:46.239Z
Learning: In packages/toolbars/preview/src/Main.vue, within the preview function, the getMergeMeta method is used at lines 64 and 65 to retrieve engine.config configurations.

Learnt from: yy-wow
PR: #850
File: packages/toolbars/preview/src/Main.vue:0-0
Timestamp: 2024-10-10T02:48:10.881Z
Learning: 在 packages/toolbars/preview/src/Main.vue 文件中，使用 useNotify 而不是 console 来记录错误日志。

Learnt from: yy-wow
PR: #886
File: packages/toolbars/generate-code/src/http.js:37-37
Timestamp: 2024-10-30T02:19:46.574Z
Learning: In packages/toolbars/generate-code/src/http.js, functions like fetchPageList do not perform parameter validation since errors are handled by the caller.

Learnt from: rhlin
PR: #1011
File: packages/canvas/render/src/application-function/global-state.ts:12-25
Timestamp: 2025-01-14T08:45:57.032Z
Learning: The code in packages/canvas/render/src/application-function/global-state.ts is migrated from an existing codebase and should be handled with care when making modifications.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: push-check

🔇 Additional comments (3)

packages/toolbars/generate-code/src/Main.vue (3)

105-118: LGTM! Effective directory handle validation implementation.

The function correctly validates directory handle accessibility by attempting to iterate over entries. The immediate break after the first iteration is an efficient approach since we only need to verify access capability, not enumerate all contents.

---

129-131: Excellent solution to the core issue.

This change effectively addresses the PR objective by replacing the simple existence check with actual validation. Now if a previously authorized directory handle becomes invalid (e.g., folder deleted), the system will properly detect this and request new authorization.

---

262-266: Good enhancement for user feedback.

The addition of directory name to the success message improves user experience by clearly indicating where files were saved. The optional chaining ensures safe access to the directory name.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.