Skip to content

Commit d32a3e9

Browse files
author
Paul Dagnelie
committed
mav's feedback
Signed-off-by: Paul Dagnelie <[email protected]>
1 parent 01c09de commit d32a3e9

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

module/zfs/zio.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3128,8 +3128,7 @@ zio_write_gang_member_ready(zio_t *zio)
31283128
for (int d = 0; d < BP_GET_NDVAS(pio->io_bp); d++) {
31293129
ASSERT(DVA_GET_GANG(&pdva[d]));
31303130
asize = DVA_GET_ASIZE(&pdva[d]);
3131-
for (int cd = 0; cd < BP_GET_NDVAS(zio->io_bp); cd++)
3132-
asize += DVA_GET_ASIZE(&cdva[cd]);
3131+
asize += DVA_GET_ASIZE(&cdva[d]);
31333132
DVA_SET_ASIZE(&pdva[d], asize);
31343133
}
31353134
mutex_exit(&pio->io_lock);

module/zfs/zio_checksum.c

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -545,15 +545,16 @@ zio_checksum_error(zio_t *zio, zio_bad_cksum_t *info)
545545
uint_t checksum = (bp == NULL ? zio->io_prop.zp_checksum :
546546
(BP_IS_GANG(bp) ? ZIO_CHECKSUM_GANG_HEADER : BP_GET_CHECKSUM(bp)));
547547
int error;
548-
uint64_t size = bp == NULL ? zio->io_size :
549-
(BP_IS_GANG(bp) ? SPA_OLD_GANGBLOCKSIZE : BP_GET_PSIZE(bp));
548+
uint64_t size = bp ? BP_GET_PSIZE(bp) : zio->io_size;
550549
uint64_t offset = zio->io_offset;
551550
abd_t *data = zio->io_abd;
552551
spa_t *spa = zio->io_spa;
553552

554-
if (bp && BP_IS_GANG(bp) && spa_feature_is_active(spa,
555-
SPA_FEATURE_DYNAMIC_GANG_HEADER)) {
556-
size = zio->io_size;
553+
if (bp && BP_IS_GANG(bp)) {
554+
if (spa_feature_is_active(spa, SPA_FEATURE_DYNAMIC_GANG_HEADER))
555+
size = zio->io_size;
556+
else
557+
size = SPA_OLD_GANGBLOCKSIZE;
557558
}
558559

559560
error = zio_checksum_error_impl(spa, bp, checksum, data, size,

0 commit comments

Comments
 (0)