Merge pull request #6568 from Wabri/feat/181409-settings

Prevent error when workers config not found, throw warning instead

Author: mergify[bot]

lib/OpenQA/Worker/Settings.pm

@@ -10,7 +10,7 @@ use Mojo::Util 'trim';
 use Config::IniFiles;
 use Time::Seconds;
 use OpenQA::Config;
-use OpenQA::Log 'setup_log';
+use OpenQA::Log qw(setup_log log_info);
 use OpenQA::Utils 'is_host_local';
 use Net::Domain 'hostfqdn';
 
@@ -23,7 +23,8 @@ use constant VNCPORT_OFFSET => $ENV{VNCPORT_OFFSET} // 90;
 sub new ($class, $instance_number = undef, $cli_options = {}) {
     my $config_paths = lookup_config_files(undef, 'workers.ini', 1);
     my $cfg = parse_config_files($config_paths);
-    my @parse_errors = @$config_paths ? (@Config::IniFiles::errors) : ('No config file found.');
+    my @parse_errors = @$config_paths ? (@Config::IniFiles::errors) : ();
+    log_info 'workers.ini not found, using default settings' unless @$config_paths;
 
     # read settings from config
     my %global_settings;

t/24-worker-settings.t

@@ -127,7 +127,7 @@ subtest 'settings file not found' => sub {
     $config_mock->redefine(_config_dirs => [['does not exist']]);
     my $settings = OpenQA::Worker::Settings->new(1);
     ok !$settings->file_path, 'no file path present';
-    is_deeply $settings->parse_errors, ['No config file found.'], 'error logged'
+    is_deeply $settings->parse_errors, [], 'no parse errors if file is missing'
       or always_explain $settings->parse_errors;
 };