Skip to content

Commit d0d1ea8

Browse files
authored
Merge pull request #6579 from okurz/fix/poo185515
Schema::Result::Jobs: Catch undefined parent jobs
2 parents 6ca3853 + 7e55425 commit d0d1ea8

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

lib/OpenQA/Schema/Result/Jobs.pm

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2237,10 +2237,10 @@ sub dependencies ($self, $children_list = undef, $parents_list = undef) {
22372237
$parents_list ||= [$self->parents->all];
22382238
for my $s (@$parents_list) {
22392239
push(@{$parents{$s->to_string}}, $s->parent_job_id);
2240-
$has_parents = 1;
22412240
my $jobs = $self->result_source->schema->resultset('Jobs');
2242-
$parents_ok = $jobs->find($s->parent_job_id, {select => ['result']})->is_ok
2243-
if $is_final && $parents_ok;
2241+
next unless my $parent = $jobs->find($s->parent_job_id, {select => ['result']});
2242+
$has_parents = 1;
2243+
$parents_ok &&= $parent->is_ok if $is_final;
22442244
}
22452245
$children_list ||= [$self->children->all];
22462246
for my $s (@$children_list) {

0 commit comments

Comments
 (0)