Skip to content

Commit fe45b37

Browse files
committed
Stop logging confusing exception when GruTask is gone
The exception is misleading as this is expected. See: https://progress.opensuse.org/issues/188007
1 parent 42965ea commit fe45b37

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

lib/OpenQA/Shared/Plugin/Gru.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ sub _add_jobs_to_gru_task ($self, $gru_id, $job_ids) {
166166
=~ m/insert or update on table "gru_dependencies" violates foreign key constraint "gru_dependencies_fk_gru_task_id"/i;
167167
# if the GruTask was already deleted meanwhile, we can skip
168168
# the rest of the jobs, since the wanted task was done
169-
log_debug("GruTask $gru_id already gone, skip assigning jobs (message: $e)");
169+
log_debug("GruTask $gru_id already gone, skip assigning jobs");
170170
last;
171171
}
172172
}

t/14-grutasks-git.t

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -378,8 +378,7 @@ subtest 'enqueue_git_clones' => sub {
378378
$t->app->log(Mojo::Log->new(level => 'debug'));
379379
my $jobs = [$j[4]->id];
380380
stderr_like { $t->app->gru->_add_jobs_to_gru_task(999, $jobs) }
381-
qr{GruTask 999 already gone.*insert or update on table "gru_dependencies" violates foreign key constraint "gru_dependencies_fk_gru_task_id"},
382-
'expected log output if GruTask deleted in between';
381+
qr{GruTask 999 already gone, skip assigning jobs}, 'expected log output if GruTask deleted in between';
383382
my @deps = $task->jobs;
384383
is scalar @deps, 3, 'no job was added to GruTask';
385384
};

0 commit comments

Comments
 (0)