From 2ba379ad17fa4c45222111c09f7fbdbba169ffc7 Mon Sep 17 00:00:00 2001
From: Wabri <gabriele.puliti@suse.com>
Date: Wed, 3 Sep 2025 16:33:24 +0200
Subject: [PATCH 1/2] Fully cover WebAPI::Plugin::ObsRsync::Controller::Folders

Reference: https://progress.opensuse.org/issues/178948
---
 lib/OpenQA/WebAPI/Plugin/ObsRsync/Controller/Folders.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/OpenQA/WebAPI/Plugin/ObsRsync/Controller/Folders.pm b/lib/OpenQA/WebAPI/Plugin/ObsRsync/Controller/Folders.pm
index f8f86e883fb..dfffe7e213c 100644
--- a/lib/OpenQA/WebAPI/Plugin/ObsRsync/Controller/Folders.pm
+++ b/lib/OpenQA/WebAPI/Plugin/ObsRsync/Controller/Folders.pm
@@ -189,6 +189,7 @@ sub forget_run_last {
     if (unlink($dest)) {
         return $self->render(json => {message => 'success'}, status => 200);
     }
+    # uncoverable statement
     return $self->render(json => {message => "error $!"}, status => 500);
 }
 

From b87ea163b47dc8fa649698d60feef3a20f850789 Mon Sep 17 00:00:00 2001
From: Wabri <gabriele.puliti@suse.com>
Date: Wed, 3 Sep 2025 16:35:30 +0200
Subject: [PATCH 2/2] Replace argument assignation with signatures Folders
 package

Reference: https://progress.opensuse.org/issues/178948
---
 .../Plugin/ObsRsync/Controller/Folders.pm     | 29 +++++++------------
 1 file changed, 10 insertions(+), 19 deletions(-)

diff --git a/lib/OpenQA/WebAPI/Plugin/ObsRsync/Controller/Folders.pm b/lib/OpenQA/WebAPI/Plugin/ObsRsync/Controller/Folders.pm
index dfffe7e213c..26db31afc52 100644
--- a/lib/OpenQA/WebAPI/Plugin/ObsRsync/Controller/Folders.pm
+++ b/lib/OpenQA/WebAPI/Plugin/ObsRsync/Controller/Folders.pm
@@ -2,14 +2,13 @@
 # SPDX-License-Identifier: GPL-2.0-or-later
 
 package OpenQA::WebAPI::Plugin::ObsRsync::Controller::Folders;
-use Mojo::Base 'Mojolicious::Controller';
+use Mojo::Base 'Mojolicious::Controller', -signatures;
 use Mojo::File;
 use POSIX 'strftime';
 
 my $non_project_folders = '^(t|profiles|script|xml)$';
 
-sub list {
-    my $self = shift;
+sub list ($self) {
     my $helper = $self->obs_rsync;
     my $folders = Mojo::File->new($helper->home)->list({dir => 1})->grep(sub { -d $_ })->map('basename')->to_array;
     my @res;
@@ -26,8 +25,7 @@ sub list {
     return $self->render(json => \@res, status => 200);
 }
 
-sub index {
-    my ($self, $obs_project, $folders) = @_;
+sub index ($self, $obs_project, $folders) {
     my $helper = $self->obs_rsync;
     my %folder_info_by_name;
     if (!$folders) {
@@ -85,8 +83,7 @@ sub index {
     $self->render('ObsRsync_index', folder_info_by_name => \%folder_info_by_name, project => $obs_project);
 }
 
-sub folder {
-    my $self = shift;
+sub folder ($self) {
     my $alias = $self->param('alias');
     my $helper = $self->obs_rsync;
     return undef if $helper->check_and_render_error($alias);
@@ -113,8 +110,7 @@ sub folder {
         openqa_sh => $files->grep(qr/print_openqa\.sh/)->join());
 }
 
-sub runs {
-    my $self = shift;
+sub runs ($self) {
     my $alias = $self->param('alias');
     my $helper = $self->obs_rsync;
     return undef if $helper->check_and_render_error($alias);
@@ -126,8 +122,7 @@ sub runs {
     $self->render('ObsRsync_logs', alias => $alias, full => $full->to_string, subfolders => $files);
 }
 
-sub run {
-    my $self = shift;
+sub run ($self) {
     my $alias = $self->param('alias');
     my $subfolder = $self->param('subfolder');
     my $helper = $self->obs_rsync;
@@ -145,8 +140,7 @@ sub run {
     );
 }
 
-sub download_file {
-    my $self = shift;
+sub download_file ($self) {
     my $alias = $self->param('alias');
     my $subfolder = $self->param('subfolder');
     my $filename = $self->param('filename');
@@ -159,8 +153,7 @@ sub download_file {
     $self->reply->file($full->child($filename));
 }
 
-sub get_run_last {
-    my $self = shift;
+sub get_run_last ($self) {
     my $alias = $self->param('alias');
     my $helper = $self->obs_rsync;
     return undef if $helper->check_and_render_error($alias);
@@ -172,8 +165,7 @@ sub get_run_last {
     return $self->render(json => {message => $run_last}, status => 200);
 }
 
-sub forget_run_last {
-    my $self = shift;
+sub forget_run_last ($self) {
     my $alias = $self->param('alias');
     my $helper = $self->obs_rsync;
     return undef if $helper->check_and_render_error($alias);
@@ -193,8 +185,7 @@ sub forget_run_last {
     return $self->render(json => {message => "error $!"}, status => 500);
 }
 
-sub test_result {
-    my $self = shift;
+sub test_result ($self) {
     my $alias = $self->param('alias');
     my $helper = $self->obs_rsync;
     return undef if $helper->check_and_render_error($alias);