Merge pull request #997 from igchor/fix_coverity

Fix coverity issues (not catching exception in dtor)

Author: lukaszstolarczuk

examples/transaction/transaction.cpp

@@ -296,7 +296,13 @@ struct simple_ptr {
 	~simple_ptr()
 	{
 		assert(pmemobj_tx_stage() == TX_STAGE_WORK);
-		delete_persistent<T>(ptr);
+
+		try {
+			delete_persistent<T>(ptr);
+		} catch (pmem::transaction_free_error &e) {
+			std::cerr << e.what() << std::endl;
+			std::terminate();
+		}
 	}
 
 	persistent_ptr<T> ptr;

tests/transaction/transaction_flat.cpp

@@ -25,7 +25,11 @@ struct simple_ptr {
 	{
 		UT_ASSERT(ptr != nullptr);
 
-		nvobj::delete_persistent<T>(ptr);
+		try {
+			nvobj::delete_persistent<T>(ptr);
+		} catch (...) {
+			UT_ASSERT(0);
+		}
 	}
 
 	nvobj::persistent_ptr<T> ptr;
@@ -44,7 +48,11 @@ struct simple_ptr_tx {
 	{
 		UT_ASSERT(ptr != nullptr);
 
-		nvobj::delete_persistent<T>(ptr);
+		try {
+			nvobj::delete_persistent<T>(ptr);
+		} catch (...) {
+			UT_ASSERT(0);
+		}
 	}
 
 	nvobj::persistent_ptr<T> ptr;