Merge pull request #656 from pycontw/fix/slido-iframe

Ritabear · web-flow · commit 391a21c245f8 · 2025-07-07T21:43:23.000+08:00
feat: lazy-loading iframes in keynotes and talks pages
diff --git a/components/core/embed/Youtube.vue b/components/core/embed/Youtube.vue
@@ -5,6 +5,7 @@
             frameborder="0"
             allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture"
             allowfullscreen
+            loading="lazy"
         >
         </iframe>
     </div>
diff --git a/components/core/tabs/Tab.vue b/components/core/tabs/Tab.vue
@@ -14,7 +14,7 @@ export default {
     },
     data() {
         return {
-            isActive: true,
+            isActive: false,
         }
     },
 }
diff --git a/pages/conference/_eventType/_id.vue b/pages/conference/_eventType/_id.vue
@@ -135,12 +135,14 @@
                 <iframe
                     class="speech__slido"
                     :src="data.slido_embed_link"
+                    loading="lazy"
                 ></iframe>
             </tab>
             <tab v-if="!!data.hackmd_embed_link" :title="$t('terms.note')">
                 <iframe
                     class="speech__hackmd"
                     :src="data.hackmd_embed_link"
+                    loading="lazy"
                 ></iframe>
             </tab>
         </tabs>
diff --git a/pages/conference/keynotes.vue b/pages/conference/keynotes.vue
@@ -95,6 +95,7 @@
                         <iframe
                             class="keynote__slido"
                             :src="keynote.slido"
+                            loading="lazy"
                         ></iframe>
                     </tab>
                     <tab
@@ -104,6 +105,7 @@
                         <iframe
                             class="keynote__hackmd"
                             :src="keynote.hackmd_embed_link"
+                            loading="lazy"
                         ></iframe>
                     </tab>
                 </tabs>

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@`
`5`	`5`	`frameborder="0"`
`6`	`6`	`allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture"`
`7`	`7`	`allowfullscreen`
	`8`	`+ loading="lazy"`
`8`	`9`	`>`
`9`	`10`	`</iframe>`
`10`	`11`	`</div>`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ export default {`
`14`	`14`	`},`
`15`	`15`	`data() {`
`16`	`16`	`return {`
`17`		`- isActive: true,`
	`17`	`+ isActive: false,`
`18`	`18`	`}`
`19`	`19`	`},`
`20`	`20`	`}`