Skip to content

add: continue partial operations in uring engine #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
VasilyStepanov wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

add: continue partial operations in uring engine #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a59e0bb
wip: uring Event
VasilyStepanov Jan 6, 2026
bea1473
add: partial support
VasilyStepanov Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion librawstorio/src/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ librawstorio_la_LIBADD =
if WITH_LIBURING
AM_CFLAGS += $(LIBURING_CFLAGS)
AM_CXXFLAGS += $(LIBURING_CFLAGS)
librawstorio_la_SOURCES += uring_queue.cpp \
librawstorio_la_SOURCES += uring_event.cpp \
uring_event.hpp \
uring_queue.cpp \
uring_queue.hpp
librawstorio_la_LIBADD += $(LIBURING_LIBS)
else
Expand Down
6 changes: 2 additions & 4 deletions librawstorio/src/poll_event.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,7 @@ ssize_t EventSimplexScalarPositionalRead::process() noexcept {
}
_result = res;
#ifdef RAWSTOR_TRACE_EVENTS
if ((size_t)_result ==
static_cast<rawstor::io::TaskScalarPositional*>(_t.get())->size()) {
if (_size_at == 0) {
trace(__FILE__, __LINE__, __FUNCTION__, "completed");
} else {
trace(__FILE__, __LINE__, __FUNCTION__, "partial");
Expand All @@ -177,8 +176,7 @@ ssize_t EventSimplexVectorPositionalRead::process() noexcept {
}
_result = res;
#ifdef RAWSTOR_TRACE_EVENTS
if ((size_t)_result ==
static_cast<rawstor::io::TaskVectorPositional*>(_t.get())->size()) {
if (_size_at == 0) {
trace(__FILE__, __LINE__, __FUNCTION__, "completed");
} else {
trace(__FILE__, __LINE__, __FUNCTION__, "partial");
Expand Down
225 changes: 225 additions & 0 deletions librawstorio/src/uring_event.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,225 @@
#include "uring_event.hpp"

#include "uring_queue.hpp"

#include <rawstorstd/iovec.h>
#include <rawstorstd/logging.h>

#include <liburing.h>

#include <sstream>

namespace rawstor {
namespace io {
namespace uring {

void Event::dispatch() {
#ifdef RAWSTOR_TRACE_EVENTS
trace(__FILE__, __LINE__, __FUNCTION__, "callback");
try {
#endif
(*_t)(_result, _error);
#ifdef RAWSTOR_TRACE_EVENTS
} catch (const std::exception& e) {
std::ostringstream oss;
oss << "callback error: " << e.what();
trace(__FILE__, __LINE__, __FUNCTION__, oss.str());
throw;
}
trace(__FILE__, __LINE__, __FUNCTION__, "callback success");
#endif
}

void EventPoll::set_result(ssize_t res) noexcept {
if (res >= 0) {
_result = res;
} else {
_error = -res;
#ifdef RAWSTOR_TRACE_EVENTS
std::ostringstream oss;
oss << "error " << _error;
trace(__FILE__, __LINE__, __FUNCTION__, oss.str());
#endif
}
}

void EventPoll::prep() {
#ifdef RAWSTOR_TRACE_EVENTS
trace(__FILE__, __LINE__, __FUNCTION__, "io_uring_prep_poll_add()");
#endif
io_uring_sqe* sqe = _q.get_sqe();
io_uring_prep_poll_add(
sqe, _t->fd(), static_cast<rawstor::io::TaskPoll*>(_t.get())->mask()
);
io_uring_sqe_set_data(sqe, this);
}

void EventScalar::set_result(ssize_t res) noexcept {
if (res >= 0) {
_buf_at = static_cast<char*>(_buf_at) + res;
_size_at -= res;
_result += res;
#ifdef RAWSTOR_TRACE_EVENTS
if (_size_at == 0) {
trace(__FILE__, __LINE__, __FUNCTION__, "completed");
} else {
trace(__FILE__, __LINE__, __FUNCTION__, "partial");
}
#endif
} else {
_error = -res;
#ifdef RAWSTOR_TRACE_EVENTS
std::ostringstream oss;
oss << "error " << _error;
trace(__FILE__, __LINE__, __FUNCTION__, oss.str());
#endif
}
}

void EventVector::set_result(ssize_t res) noexcept {
if (res >= 0) {
rawstor_iovec_discard_front(&_iov_at, &_niov_at, res);
_size_at -= res;
_result += res;
#ifdef RAWSTOR_TRACE_EVENTS
if (_size_at == 0) {
trace(__FILE__, __LINE__, __FUNCTION__, "completed");
} else {
trace(__FILE__, __LINE__, __FUNCTION__, "partial");
}
#endif
} else {
_error = -res;
#ifdef RAWSTOR_TRACE_EVENTS
std::ostringstream oss;
oss << "error " << _error;
trace(__FILE__, __LINE__, __FUNCTION__, oss.str());
#endif
}
}

void EventScalarRead::prep() {
#ifdef RAWSTOR_TRACE_EVENTS
trace(__FILE__, __LINE__, __FUNCTION__, "io_uring_prep_read()");
#endif
io_uring_sqe* sqe = _q.get_sqe();
io_uring_prep_read(sqe, _t->fd(), _buf_at, _size_at, 0);
io_uring_sqe_set_data(sqe, this);
}

void EventVectorRead::prep() {
#ifdef RAWSTOR_TRACE_EVENTS
trace(__FILE__, __LINE__, __FUNCTION__, "io_uring_prep_readv()");
#endif
io_uring_sqe* sqe = _q.get_sqe();
io_uring_prep_readv(
sqe, _t->fd(), static_cast<rawstor::io::TaskVector*>(_t.get())->iov(),
static_cast<rawstor::io::TaskVector*>(_t.get())->niov(), 0
);
io_uring_sqe_set_data(sqe, this);
}

void EventScalarPositionalRead::prep() {
#ifdef RAWSTOR_TRACE_EVENTS
trace(__FILE__, __LINE__, __FUNCTION__, "io_uring_prep_read()");
#endif
io_uring_sqe* sqe = _q.get_sqe();
io_uring_prep_read(
sqe, _t->fd(),
static_cast<rawstor::io::TaskScalarPositional*>(_t.get())->buf(),
static_cast<rawstor::io::TaskScalarPositional*>(_t.get())->size(),
static_cast<rawstor::io::TaskScalarPositional*>(_t.get())->offset()
);
io_uring_sqe_set_data(sqe, this);
}

void EventVectorPositionalRead::prep() {
#ifdef RAWSTOR_TRACE_EVENTS
trace(__FILE__, __LINE__, __FUNCTION__, "io_uring_prep_readv()");
#endif
io_uring_sqe* sqe = _q.get_sqe();
io_uring_prep_readv(
sqe, _t->fd(),
static_cast<rawstor::io::TaskVectorPositional*>(_t.get())->iov(),
static_cast<rawstor::io::TaskVectorPositional*>(_t.get())->niov(),
static_cast<rawstor::io::TaskVectorPositional*>(_t.get())->offset()
);
io_uring_sqe_set_data(sqe, this);
}

void EventMessageRead::prep() {
#ifdef RAWSTOR_TRACE_EVENTS
trace(__FILE__, __LINE__, __FUNCTION__, "io_uring_prep_recvmsg()");
#endif
io_uring_sqe* sqe = _q.get_sqe();
io_uring_prep_recvmsg(
sqe, _t->fd(), static_cast<rawstor::io::TaskMessage*>(_t.get())->msg(),
static_cast<rawstor::io::TaskMessage*>(_t.get())->flags()
);
io_uring_sqe_set_data(sqe, this);
}

void EventScalarWrite::prep() {
#ifdef RAWSTOR_TRACE_EVENTS
trace(__FILE__, __LINE__, __FUNCTION__, "io_uring_prep_write()");
#endif
io_uring_sqe* sqe = _q.get_sqe();
io_uring_prep_write(sqe, _t->fd(), _buf_at, _size_at, 0);
io_uring_sqe_set_data(sqe, this);
}

void EventVectorWrite::prep() {
#ifdef RAWSTOR_TRACE_EVENTS
trace(__FILE__, __LINE__, __FUNCTION__, "io_uring_prep_writev()");
#endif
io_uring_sqe* sqe = _q.get_sqe();
io_uring_prep_writev(
sqe, _t->fd(), static_cast<rawstor::io::TaskVector*>(_t.get())->iov(),
static_cast<rawstor::io::TaskVector*>(_t.get())->niov(), 0
);
io_uring_sqe_set_data(sqe, this);
}

void EventScalarPositionalWrite::prep() {
#ifdef RAWSTOR_TRACE_EVENTS
trace(__FILE__, __LINE__, __FUNCTION__, "io_uring_prep_write()");
#endif
io_uring_sqe* sqe = _q.get_sqe();
io_uring_prep_write(
sqe, _t->fd(),
static_cast<rawstor::io::TaskScalarPositional*>(_t.get())->buf(),
static_cast<rawstor::io::TaskScalarPositional*>(_t.get())->size(),
static_cast<rawstor::io::TaskScalarPositional*>(_t.get())->offset()
);
io_uring_sqe_set_data(sqe, this);
}

void EventVectorPositionalWrite::prep() {
#ifdef RAWSTOR_TRACE_EVENTS
trace(__FILE__, __LINE__, __FUNCTION__, "io_uring_prep_writev()");
#endif
io_uring_sqe* sqe = _q.get_sqe();
io_uring_prep_writev(
sqe, _t->fd(),
static_cast<rawstor::io::TaskVectorPositional*>(_t.get())->iov(),
static_cast<rawstor::io::TaskVectorPositional*>(_t.get())->niov(),
static_cast<rawstor::io::TaskVectorPositional*>(_t.get())->offset()
);
io_uring_sqe_set_data(sqe, this);
}

void EventMessageWrite::prep() {
#ifdef RAWSTOR_TRACE_EVENTS
trace(__FILE__, __LINE__, __FUNCTION__, "io_uring_prep_sendmsg()");
#endif
io_uring_sqe* sqe = _q.get_sqe();
io_uring_prep_sendmsg(
sqe, _t->fd(), static_cast<rawstor::io::TaskMessage*>(_t.get())->msg(),
static_cast<rawstor::io::TaskMessage*>(_t.get())->flags()
);
io_uring_sqe_set_data(sqe, this);
}

} // namespace uring
} // namespace io
} // namespace rawstor
Loading
Loading