From 9aac337f00e7f05c06defdc95921719307dc3fc9 Mon Sep 17 00:00:00 2001
From: Umanga Chapagain <uchapaga@redhat.com>
Date: Tue, 29 Apr 2025 13:35:58 +0530
Subject: [PATCH] handle corner cases for StorageID generation

There can be cases where Ceph FSID is not yet initialized or missing
from the server response. In such cases, it is better to error out
early than to proceed with incorrect state.

Signed-off-by: Umanga Chapagain <uchapaga@redhat.com>
---
 controllers/utils/hash_test.go    | 61 +++++++++++++++++++++++++++++++
 controllers/utils/storageclass.go |  5 ++-
 2 files changed, 65 insertions(+), 1 deletion(-)

diff --git a/controllers/utils/hash_test.go b/controllers/utils/hash_test.go
index af9c70fc..9536015b 100644
--- a/controllers/utils/hash_test.go
+++ b/controllers/utils/hash_test.go
@@ -21,3 +21,64 @@ func TestFnvHashTest(t *testing.T) {
 		}
 	}
 }
+
+func TestCalculateMD5Hash(t *testing.T) {
+	type args struct {
+		value any
+	}
+	tests := []struct {
+		name string
+		args args
+		want string
+	}{
+		{
+			name: "RBD with empty CephFSID",
+			args: args{
+				value: [2]string{"", ""},
+			},
+			want: "2432510f5993984b053e7d74ce53d94c",
+		},
+		{
+			name: "CephFS with empty CephFSID",
+			args: args{
+				value: [2]string{"", "csi"},
+			},
+			want: "793b48b9b17bdad5cd141e6daadfdd4e",
+		},
+		{
+			name: "C1/RBD",
+			args: args{
+				value: [2]string{"a0eaa723-bf87-48db-ad11-17e276edda61", ""},
+			},
+			want: "bb2361459436fd47121419c658d4c79b",
+		},
+		{
+			name: "C1/CephFS",
+			args: args{
+				value: [2]string{"a0eaa723-bf87-48db-ad11-17e276edda61", "csi"},
+			},
+			want: "41711cb35464e85f4446ace583adbaa1",
+		},
+		{
+			name: "C2/RBD",
+			args: args{
+				value: [2]string{"30dc85db-f35f-4c03-bb43-c8592487d8b9", ""},
+			},
+			want: "9e4fbb3d9e52875d6393409a51927243",
+		},
+		{
+			name: "C2/CephFS",
+			args: args{
+				value: [2]string{"30dc85db-f35f-4c03-bb43-c8592487d8b9", "csi"},
+			},
+			want: "4b7e331b508946ca7165f14804c37ffc",
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if got := CalculateMD5Hash(tt.args.value); got != tt.want {
+				t.Errorf("CalculateMD5Hash() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}
diff --git a/controllers/utils/storageclass.go b/controllers/utils/storageclass.go
index 262229df..ad775917 100644
--- a/controllers/utils/storageclass.go
+++ b/controllers/utils/storageclass.go
@@ -102,8 +102,11 @@ func CalculateStorageId(ctx context.Context, c client.Client, sc storagev1.Stora
 	}
 
 	cephClusterFSID := cephCluster.Status.CephStatus.FSID
-	var storageId string
+	if cephClusterFSID == "" {
+		return "", fmt.Errorf("failed to calculate StorageID. Ceph FSID is empty")
+	}
 
+	var storageId string
 	switch sc.Provisioner {
 	case fmt.Sprintf(RBDProvisionerTemplate, storageClusterNamespacedName.Namespace):
 		radosNamespaceName := DefaultRadosNamespace